Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(native): Initial support for native api-gateway #8472

Merged
merged 13 commits into from
Jul 22, 2024

Conversation

ovr
Copy link
Member

@ovr ovr commented Jul 17, 2024

No description provided.

Copy link

vercel bot commented Jul 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Jul 22, 2024 0:44am
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Jul 22, 2024 0:44am
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Jul 22, 2024 0:44am
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Jul 22, 2024 0:44am
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Jul 22, 2024 0:44am
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Jul 22, 2024 0:44am
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Jul 22, 2024 0:44am
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Jul 22, 2024 0:44am

@@ -497,6 +498,20 @@
}));
}

app.all(
`${this.basePath}/v2/stream`,
userMiddlewares,

Check failure

Code scanning / CodeQL

Missing rate limiting High

This route handler performs
authorization
, but is not rate-limited.
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.94%. Comparing base (f77c3aa) to head (83e1802).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8472      +/-   ##
==========================================
+ Coverage   81.93%   81.94%   +0.01%     
==========================================
  Files         199      199              
  Lines       76201    76201              
==========================================
+ Hits        62434    62442       +8     
+ Misses      13767    13759       -8     
Flag Coverage Δ
cubesql 81.94% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ovr ovr force-pushed the feat/native-api-gateway branch 2 times, most recently from ae0b471 to 5ce17de Compare July 17, 2024 14:55
packages/cubejs-api-gateway/src/gateway.ts Dismissed Show dismissed Hide dismissed
@ovr ovr force-pushed the feat/native-api-gateway branch from 5ea795d to 53cfa48 Compare July 21, 2024 16:21
@ovr ovr marked this pull request as ready for review July 22, 2024 12:31
@ovr ovr requested review from a team as code owners July 22, 2024 12:31
@ovr ovr force-pushed the feat/native-api-gateway branch from d47bd35 to 8c5c69b Compare July 22, 2024 12:36
@ovr ovr merged commit d917d6f into master Jul 22, 2024
69 checks passed
@ovr ovr deleted the feat/native-api-gateway branch July 22, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants