-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add Healthcheck API endpoints to 'REST API' page #1802
Conversation
Looks good! Should we share in more details what is tested both on readyz and livez? E.g. database connection. What do you think? @hassankhan @paveltiunov @ovr |
@keydunov That sounds like a great idea 👍 WDYT of the following?: /readyzReturns the ready state of the deployment. Ensures that a successful connection is set up between Cube.js and its' cache and queue. /livezReturns the liveness state of the deployment. Ensures that a successful connection is set up between Cube.js and all of the configured data sources. |
There are some details about the testing database connection with single-tenant setup vs multi-tenant. AFAIK readyz does the database test as well, but only for single-tenant applications. |
|
||
### /readyz | ||
|
||
Returns the ready state of the deployment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add details that:
For single tenant: It's open a new OrchestratorApi
(I don't know how to name it in documentation) for default datasource to test connection?
For multi tenancy: It checks only created connections per tenant via OrchestratorApi
(datasources), if no connections exist it will return OK.
How it stores connections:
SingleTenant:
- OrchestratorApi (multi sources can exists)
- DataSource1
- DataSource2
MultiTenant:
- Tenant1
- OrchestratorApi (multi sources can exists)
- DataSource1
- DataSource2
- Tenant2
- OrchestratorApi (multi sources can exists)
- DataSource1
- DataSource2
P.S
It's test connection to queue/cache driver, but it's similar for now.
16c49e0
to
d39277f
Compare
d39277f
to
b823f6c
Compare
Check List
Description of Changes Made (if issue reference is not provided)
Followup for #1607