Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Suggest export/unload for large pre-aggregations (detect via st… #2930

Merged
merged 1 commit into from
Jun 11, 2021

Conversation

ovr
Copy link
Member

@ovr ovr commented Jun 9, 2021

…reaming)

Hello!

Thanks

@ovr ovr requested a review from a team as a code owner June 9, 2021 16:42
@codecov
Copy link

codecov bot commented Jun 9, 2021

Codecov Report

Merging #2930 (7ced216) into master (0f83356) will decrease coverage by 0.09%.
The diff coverage is 48.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2930      +/-   ##
==========================================
- Coverage   56.90%   56.81%   -0.10%     
==========================================
  Files         117      118       +1     
  Lines        9053     9071      +18     
  Branches     1974     1975       +1     
==========================================
+ Hits         5152     5154       +2     
- Misses       3558     3574      +16     
  Partials      343      343              
Impacted Files Coverage Δ
...ages/cubejs-query-orchestrator/src/driver/utils.ts 100.00% <ø> (ø)
...hestrator/src/orchestrator/StreamObjectsCounter.ts 30.76% <30.76%> (ø)
...y-orchestrator/src/orchestrator/PreAggregations.ts 89.06% <61.11%> (-0.26%) ⬇️
packages/cubejs-backend-shared/src/env.ts 38.23% <0.00%> (-1.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f83356...7ced216. Read the comment docs.

@ovr ovr force-pushed the stream-suggest-unload-warning branch 3 times, most recently from 30052be to 5ecd9ee Compare June 9, 2021 18:14
@ovr ovr force-pushed the stream-suggest-unload-warning branch from 5ecd9ee to 7ced216 Compare June 9, 2021 18:21
@ovr ovr merged commit b20cdbc into master Jun 11, 2021
@ovr ovr deleted the stream-suggest-unload-warning branch June 11, 2021 10:18
@rpaik rpaik added Roadmap: 2021 Q2 Cube.js team roadmap for Q1 of 2021. backend:pre-aggregations Issues related to pre-aggregations labels Jul 1, 2021
@rpaik rpaik added this to In progress in Roadmap 2021 Q2 via automation Jul 1, 2021
@rpaik rpaik linked an issue Jul 1, 2021 that may be closed by this pull request
4 tasks
@rpaik rpaik moved this from In progress to Done in Roadmap 2021 Q2 Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend:pre-aggregations Issues related to pre-aggregations Roadmap: 2021 Q2 Cube.js team roadmap for Q1 of 2021.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Epic: Improve Pre-Aggregations Developer Experience
3 participants