Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Mixed rolling window and regular measure queries from rollup support #3326

Merged
merged 5 commits into from
Aug 31, 2021

Conversation

paveltiunov
Copy link
Member

@paveltiunov paveltiunov commented Aug 26, 2021

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

#3237

@paveltiunov paveltiunov requested a review from a team as a code owner August 26, 2021 06:51
@github-actions github-actions bot added the pr:community Contribution from Cube.js community members. label Aug 26, 2021
@paveltiunov paveltiunov removed the pr:community Contribution from Cube.js community members. label Aug 26, 2021
@codecov
Copy link

codecov bot commented Aug 26, 2021

Codecov Report

Merging #3326 (730d846) into master (a2177e6) will decrease coverage by 0.11%.
The diff coverage is 47.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3326      +/-   ##
==========================================
- Coverage   58.97%   58.85%   -0.12%     
==========================================
  Files         124      124              
  Lines        9754     9806      +52     
  Branches     2122     2136      +14     
==========================================
+ Hits         5752     5771      +19     
- Misses       3716     3745      +29     
- Partials      286      290       +4     
Impacted Files Coverage Δ
...ejs-schema-compiler/src/adapter/PreAggregations.js 53.97% <0.00%> (-0.31%) ⬇️
packages/cubejs-backend-shared/src/time.ts 29.85% <20.00%> (-2.85%) ⬇️
.../cubejs-schema-compiler/src/adapter/BaseMeasure.js 83.33% <20.00%> (-3.73%) ⬇️
...es/cubejs-schema-compiler/src/adapter/BaseQuery.js 62.67% <46.87%> (-0.20%) ⬇️
...s-schema-compiler/src/adapter/BaseTimeDimension.js 80.39% <60.00%> (-2.95%) ⬇️
...orchestrator/src/orchestrator/QueryOrchestrator.ts 63.15% <66.66%> (-0.24%) ⬇️
...y-orchestrator/src/orchestrator/PreAggregations.ts 84.10% <69.23%> (-0.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6e908e...730d846. Read the comment docs.

@rpaik rpaik added Roadmap: 2021 Q3 Cube.js team roadmap for Q3 of 2021. backend:pre-aggregations Issues related to pre-aggregations labels Aug 27, 2021
@rpaik rpaik added this to In progress in Roadmap 2021 Q3 via automation Aug 27, 2021
@rpaik rpaik linked an issue Aug 27, 2021 that may be closed by this pull request
3 tasks
@paveltiunov paveltiunov merged commit 3147e33 into master Aug 31, 2021
@paveltiunov paveltiunov deleted the mixed-rolling-window branch August 31, 2021 02:58
Roadmap 2021 Q3 automation moved this from In progress to Done Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend:pre-aggregations Issues related to pre-aggregations Roadmap: 2021 Q3 Cube.js team roadmap for Q3 of 2021.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Epic: New rollup pre-aggregations
2 participants