Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refresh process for useOriginalSqlPreAggregations is broken #3826

Merged
merged 1 commit into from Dec 19, 2021

Conversation

paveltiunov
Copy link
Member

@paveltiunov paveltiunov commented Dec 19, 2021

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@paveltiunov paveltiunov requested a review from a team as a code owner December 19, 2021 06:06
@codecov
Copy link

codecov bot commented Dec 19, 2021

Codecov Report

Merging #3826 (2899f5c) into master (b2d4b53) will increase coverage by 0.44%.
The diff coverage is 88.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3826      +/-   ##
==========================================
+ Coverage   57.57%   58.01%   +0.44%     
==========================================
  Files         126      126              
  Lines       10576    10593      +17     
  Branches     2504     2508       +4     
==========================================
+ Hits         6089     6146      +57     
+ Misses       4204     4164      -40     
  Partials      283      283              
Impacted Files Coverage Δ
packages/cubejs-api-gateway/src/gateway.ts 67.35% <ø> (ø)
...-query-orchestrator/src/orchestrator/QueryCache.ts 80.66% <ø> (ø)
...y-orchestrator/src/orchestrator/PreAggregations.ts 80.76% <33.33%> (+0.14%) ⬆️
...es/cubejs-server-core/src/core/RefreshScheduler.ts 88.18% <100.00%> (+18.72%) ⬆️
...ackages/cubejs-server-core/src/core/CompilerApi.js 75.32% <0.00%> (+3.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 518281d...2899f5c. Read the comment docs.

@paveltiunov paveltiunov merged commit f0bf070 into master Dec 19, 2021
@paveltiunov paveltiunov deleted the refresh-worker-original-sql branch December 19, 2021 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant