Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refreshKey is evaluated ten times more frequently if sql and… #3873

Merged
merged 2 commits into from Jan 5, 2022

Conversation

paveltiunov
Copy link
Member

@paveltiunov paveltiunov commented Jan 4, 2022

every are simultaneously defined

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@paveltiunov paveltiunov requested a review from a team as a code owner January 4, 2022 20:33
…nd `every` are simultaneously defined -- tests
@codecov
Copy link

codecov bot commented Jan 4, 2022

Codecov Report

Merging #3873 (f8a2f37) into master (065938b) will not change coverage.
The diff coverage is 60.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3873   +/-   ##
=======================================
  Coverage   58.05%   58.05%           
=======================================
  Files         126      126           
  Lines       10602    10602           
  Branches     2512     2514    +2     
=======================================
  Hits         6155     6155           
+ Misses       4164     4163    -1     
- Partials      283      284    +1     
Impacted Files Coverage Δ
...es/cubejs-schema-compiler/src/adapter/BaseQuery.js 63.66% <60.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ff7e4c...f8a2f37. Read the comment docs.

@paveltiunov paveltiunov merged commit c93ae12 into master Jan 5, 2022
@paveltiunov paveltiunov deleted the fix-refresh-key-sql-every-renewal branch January 5, 2022 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant