Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cubesql): Support prepared statements in MySQL protocol #4005

Merged
merged 4 commits into from Feb 3, 2022

Conversation

ovr
Copy link
Member

@ovr ovr commented Jan 31, 2022

Hello!

This feature is required for Tableau, which is a popular BI system.

Thanks

@ovr ovr force-pushed the cubesql-prepared-statements-support branch from 76e5ec9 to ed2bb93 Compare January 31, 2022 16:08
@codecov
Copy link

codecov bot commented Jan 31, 2022

Codecov Report

Merging #4005 (f150ba2) into master (262314d) will decrease coverage by 0.12%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4005      +/-   ##
==========================================
- Coverage   62.26%   62.13%   -0.13%     
==========================================
  Files         176      176              
  Lines       15069    15099      +30     
  Branches     2518     2518              
==========================================
  Hits         9382     9382              
- Misses       5407     5437      +30     
  Partials      280      280              
Flag Coverage Δ
cube-backend 57.98% <ø> (ø)
cubesql 72.12% <0.00%> (-0.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/cubesql/cubesql/src/mysql/server_manager.rs 0.00% <0.00%> (ø)
rust/cubesql/cubesql/src/mysql/service.rs 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 262314d...f150ba2. Read the comment docs.

@ovr ovr changed the title Cubesql prepared statements support feat(cubesql): Support prepared statements in MySQL protocol Jan 31, 2022
@ovr ovr force-pushed the cubesql-prepared-statements-support branch from ed2bb93 to 6b69530 Compare February 1, 2022 09:24
@ovr ovr force-pushed the cubesql-prepared-statements-support branch from 9ddcce8 to f150ba2 Compare February 3, 2022 10:47
@ovr ovr marked this pull request as ready for review February 3, 2022 12:37
@ovr ovr requested a review from a team as a code owner February 3, 2022 12:37
@ovr ovr merged commit 6b2f61c into master Feb 3, 2022
@ovr ovr deleted the cubesql-prepared-statements-support branch February 3, 2022 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant