fix(compiler): add strictness to booleans in definition #4157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr:community
Codecov Report
@@ Coverage Diff @@
## master #4157 +/- ##
==========================================
- Coverage 58.82% 58.77% -0.05%
==========================================
Files 133 133
Lines 10846 10846
Branches 2558 2558
==========================================
- Hits 6380 6375 -5
- Misses 4186 4191 +5
Partials 280 280
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Hey @zpencerq ! Great catch! Looks good to me! Thanks for contributing it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Description of Changes Made (if issue reference is not provided)
Updates schema definitions to be strict on all boolean fields. This aligns with the schema defined in
cubejs-client-core. Previously it was valid to pass along the string"false"to fields likeshownin the cube measure definition, this would be reflected in API responses to clients. As a result, the client library wouldn't effectively filter on justmeasure.isVisibledue of truthiness semantics in JS.This is a bit of a blind change across the board so some review of the other boolean fields should be done before merging.