Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cubesql): Projection aggregate split to support Tableau casts #4435

Merged
merged 1 commit into from Apr 23, 2022

Conversation

paveltiunov
Copy link
Member

@paveltiunov paveltiunov commented Apr 23, 2022

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@paveltiunov paveltiunov requested a review from a team as a code owner April 23, 2022 04:53
@codecov
Copy link

codecov bot commented Apr 23, 2022

Codecov Report

Merging #4435 (6d258e3) into master (44469b8) will decrease coverage by 9.17%.
The diff coverage is 97.86%.

@@            Coverage Diff             @@
##           master    #4435      +/-   ##
==========================================
- Coverage   78.70%   69.53%   -9.18%     
==========================================
  Files         106      241     +135     
  Lines       12329    23475   +11146     
  Branches        0     2611    +2611     
==========================================
+ Hits         9704    16323    +6619     
- Misses       2625     6850    +4225     
- Partials        0      302     +302     
Flag Coverage Δ
cube-backend 58.78% <ø> (?)
cubesql 78.98% <97.86%> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...t/cubesql/cubesql/src/compile/rewrite/converter.rs 81.21% <ø> (ø)
rust/cubesql/cubesql/src/sql/postgres/extended.rs 84.83% <0.00%> (-0.48%) ⬇️
rust/cubesql/cubesql/src/transport/ext.rs 74.59% <80.00%> (+0.23%) ⬆️
...st/cubesql/cubesql/src/compile/rewrite/language.rs 69.42% <85.71%> (+0.55%) ⬆️
rust/cubesql/cubesql/src/compile/mod.rs 70.63% <100.00%> (+0.38%) ⬆️
...st/cubesql/cubesql/src/compile/rewrite/analysis.rs 96.38% <100.00%> (+1.25%) ⬆️
rust/cubesql/cubesql/src/compile/rewrite/mod.rs 92.44% <100.00%> (+0.20%) ⬆️
...st/cubesql/cubesql/src/compile/rewrite/rewriter.rs 100.00% <100.00%> (ø)
...cubesql/cubesql/src/compile/rewrite/rules/dates.rs 100.00% <100.00%> (ø)
...besql/cubesql/src/compile/rewrite/rules/members.rs 98.77% <100.00%> (-0.01%) ⬇️
... and 138 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44469b8...6d258e3. Read the comment docs.

@paveltiunov paveltiunov merged commit 1550774 into master Apr 23, 2022
@paveltiunov paveltiunov deleted the projection-aggregate-split branch April 23, 2022 17:28
@rpaik rpaik added this to In Progress in Roadmap 2022 Q1 via automation May 3, 2022
@rpaik rpaik added the Roadmap: 2022 Q1 Cube roadmap for Q1 of 2022 label May 3, 2022
@rpaik rpaik linked an issue May 3, 2022 that may be closed by this pull request
7 tasks
@rpaik rpaik moved this from In Progress to Done in Roadmap 2022 Q1 May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Roadmap: 2022 Q1 Cube roadmap for Q1 of 2022
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Epic: Connectors for additional BI tools
2 participants