Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cubestore): Storing aggregating index #4599

Merged
merged 6 commits into from
May 27, 2022
Merged

feat(cubestore): Storing aggregating index #4599

merged 6 commits into from
May 27, 2022

Conversation

waralex
Copy link
Contributor

@waralex waralex commented May 25, 2022

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made (if issue reference is not provided)

This is part of the aggregating index implementation related to pre-aggregation during import and compaction

@waralex waralex requested a review from a team as a code owner May 25, 2022 17:39
@github-actions github-actions bot added the pr:community Contribution from Cube.js community members. label May 25, 2022
@waralex waralex changed the title feat(cubestore): Storinng aggregating index store feat(cubestore): Storing aggregating index May 25, 2022
cristipp
cristipp reviewed May 26, 2022
View reviewed changes
Copy link
Contributor

@cristipp cristipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sprinkled in a few notes. Looks clean, biggest hurdle is the lack of docstrings to explain a bit the intent in plain English.

rust/cubestore/cubestore/src/metastore/table.rs Show resolved Hide resolved
rust/cubestore/cubestore/src/store/compaction.rs Show resolved Hide resolved
rust/cubestore/cubestore/src/store/compaction.rs Show resolved Hide resolved
rust/cubestore/cubestore/src/store/mod.rs Outdated Show resolved Hide resolved
rust/cubestore/cubestore/src/store/mod.rs Outdated Show resolved Hide resolved
rust/cubestore/cubestore/src/store/mod.rs Show resolved Hide resolved
@waralex waralex merged commit 145c7c2 into features/aggregating_index May 27, 2022
@waralex waralex deleted the features/aggregating_index_store branch May 27, 2022 14:46
waralex added a commit that referenced this pull request Jun 23, 2022
@waralex
feat(cubestore): Aggregating index (#4379)
a0bd36c 
* feat(cubestore): Storing aggregating index (#4599)
* feat(cubestore): Using aggregating indexes in queries (#4728)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristipp cristipp cristipp left review comments

Assignees
No one assigned
Labels
pr:community Contribution from Cube.js community members.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@waralex @cristipp