Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cubesql): Metabase interval date range filter support #4763

Merged
merged 5 commits into from
Jun 24, 2022

Conversation

gandronchik
Copy link
Contributor

No description provided.

@gandronchik gandronchik requested a review from a team as a code owner June 16, 2022 10:39
@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #4763 (c838e64) into master (f1cdf55) will increase coverage by 13.29%.
The diff coverage is 84.61%.

@@             Coverage Diff             @@
##           master    #4763       +/-   ##
===========================================
+ Coverage   59.15%   72.44%   +13.29%     
===========================================
  Files         136      255      +119     
  Lines       11186    27896    +16710     
  Branches     2687     2781       +94     
===========================================
+ Hits         6617    20210    +13593     
- Misses       4268     7181     +2913     
- Partials      301      505      +204     
Flag Coverage Δ
cube-backend 59.14% <ø> (-0.01%) ⬇️
cubesql 81.35% <84.61%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...st/cubesql/cubesql/src/compile/rewrite/analysis.rs 92.54% <60.00%> (ø)
rust/cubesql/cubesql/src/compile/mod.rs 76.90% <93.33%> (ø)
rust/cubesql/cubesql/src/compile/engine/udf.rs 88.12% <100.00%> (ø)
...cubesql/cubesql/src/compile/rewrite/rules/dates.rs 100.00% <100.00%> (ø)
packages/cubejs-backend-shared/src/env.ts 31.66% <0.00%> (-0.18%) ⬇️
packages/cubejs-api-gateway/src/jwk.ts 11.47% <0.00%> (ø)
packages/cubejs-api-gateway/src/gateway.ts 69.23% <0.00%> (ø)
packages/cubejs-api-gateway/src/graphql.ts 4.16% <0.00%> (ø)
packages/cubejs-backend-shared/src/time.ts 28.57% <0.00%> (ø)
packages/cubejs-backend-shared/src/proxy.ts 23.52% <0.00%> (ø)
... and 147 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1cdf55...c838e64. Read the comment docs.

@gandronchik gandronchik merged commit 221715a into master Jun 24, 2022
@gandronchik gandronchik deleted the cubesql-metabase-interval-date-range branch June 24, 2022 12:27
@rpaik rpaik added the Roadmap: 2022 Q2 Cube roadmap for Q2 of 2022 label Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Roadmap: 2022 Q2 Cube roadmap for Q2 of 2022
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants