fix(api-gateway): Catch error from contextToApiScopes #7521
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
7 Ignored Deployments
|
| } catch (e: unknown) { | ||
| if (e instanceof CubejsHandlerError) { | ||
| res.status(e.status).json({ error: e.message }); | ||
| } |
There was a problem hiding this comment.
There is no call for next when error != CubejsHandlerError.
This will lead to unhandled connection.
| ); | ||
| if (next) next(); | ||
| } catch (e: unknown) { | ||
| if (e instanceof CubejsHandlerError) { |
There was a problem hiding this comment.
There is no call for next when error != CubejsHandlerError.
This will lead to unhandled connection.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
| }, | ||
| ], | ||
| userMiddlewares, |
Check failure
Code scanning / CodeQL
Missing rate limiting High
| } | ||
| }, | ||
| ], | ||
| userMiddlewares, |
Check failure
Code scanning / CodeQL
Missing rate limiting High
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7521 +/- ##
==========================================
- Coverage 48.02% 48.02% -0.01%
==========================================
Files 154 154
Lines 20903 20893 -10
Branches 5373 5378 +5
==========================================
- Hits 10039 10033 -6
+ Misses 10122 10120 -2
+ Partials 742 740 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hello!
Thanks