feat(duckdb-driver): Add support for local fs duckdb database path #7799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for duckdb database file path
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 8 Ignored Deployments
|
github-actions
bot
added
the
pr:community
|
@JichaoS Thanks for the contribution! GitHub tells this PR conflicts with the main branch. Could you please resolve that? |
Done! |
Parameter must be undefined if no fields.
Fix linter errors
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7799 +/- ##
===========================================
- Coverage 67.88% 47.95% -19.94%
===========================================
Files 345 154 -191
Lines 58124 20969 -37155
Branches 5394 5394
===========================================
- Hits 39459 10056 -29403
+ Misses 17918 10166 -7752
Partials 747 747
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
paveltiunov
changed the title
paveltiunov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Issue Reference this PR resolves
#7653
Description of Changes Made (if issue reference is not provided)
Creates a new env var that allows users to define a duckdb local file.
Testing coverage is on par with existing CUBEJS_DB_DUCKDB_MOTHERDUCK_TOKEN