Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(schema-compiler): composite key generation #7929

Merged
merged 4 commits into from
Mar 15, 2024

Conversation

vasilev-alex
Copy link
Member

No description provided.

@vasilev-alex vasilev-alex requested a review from a team as a code owner March 15, 2024 08:19
Copy link

vercel bot commented Mar 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-react-dashboard 🔄 Building (Inspect) Visit Preview 💬 Add feedback Mar 15, 2024 8:28am
examples-react-data-table 🔄 Building (Inspect) Visit Preview 💬 Add feedback Mar 15, 2024 8:28am
6 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Mar 15, 2024 8:28am
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Mar 15, 2024 8:28am
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Mar 15, 2024 8:28am
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Mar 15, 2024 8:28am
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Mar 15, 2024 8:28am
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Mar 15, 2024 8:28am

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 48.02%. Comparing base (75bc6c3) to head (9a146f2).
Report is 1 commits behind head on master.

Files Patch % Lines
.../src/scaffolding/formatters/BaseSchemaFormatter.ts 87.50% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #7929       +/-   ##
===========================================
- Coverage   72.37%   48.02%   -24.35%     
===========================================
  Files         192      154       -38     
  Lines       27464    21019     -6445     
  Branches        0     5264     +5264     
===========================================
- Hits        19877    10095     -9782     
- Misses       7587    10723     +3136     
- Partials        0      201      +201     
Flag Coverage Δ
cube-backend 48.02% <87.50%> (?)
cubesql ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vasilev-alex vasilev-alex merged commit 5a27200 into master Mar 15, 2024
38 checks passed
@vasilev-alex vasilev-alex deleted the composite-key-generation branch March 15, 2024 08:45
vasilev-alex added a commit that referenced this pull request Mar 21, 2024
JichaoS pushed a commit to luabase/cube that referenced this pull request May 7, 2024
JichaoS pushed a commit to luabase/cube that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant