Skip to content

Commit

Permalink
Add todo.
Browse files Browse the repository at this point in the history
  • Loading branch information
cube2222 committed Aug 7, 2023
1 parent 5372273 commit d49fbe7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion arrowexec/nodes/group_by.go
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@ func (key *KeyInt) GetBatch(length int, offset int) arrow.Array {
}

type KeyString struct {
// TODO: Refactor to use custom array data.
// TODO: Use a LargeStringArray, instead of a StringArray.
// We use a custom set of buffers, rather than using the builder, because accessing elements of the builder is slow.
offsetsData *memory.Buffer // TODO: Release these buffers at some point.
offsetsState []int32 // This uses the above data as the storage underneath.
Expand Down

0 comments on commit d49fbe7

Please sign in to comment.