Add specific exception

composer.json

@@ -34,6 +34,7 @@
         "phpstan/phpstan": "^1.10.40",
         "phpunit/phpunit": "^10.4.2",
         "psalm/plugin-phpunit": "^0.18.4",
+        "thecodingmachine/safe": "^2.5",
         "vimeo/psalm": "^5.15"
     },
     "autoload": {

src/DecodeToken.php

@@ -5,12 +5,14 @@
 namespace Tuupola\Middleware;
 
 use DateTimeImmutable;
-use Exception;
 use Lcobucci\JWT\Parser as ParserInterface;
 use Lcobucci\JWT\Token\Plain;
 use Psr\Log\LoggerInterface;
 use Throwable;
 
+/**
+ * @internal
+ */
 final class DecodeToken
 {
     public function __construct(
@@ -23,23 +25,25 @@ public function __construct(
      * Decode the token.
      *
      * @param non-empty-string $token
+     *
+     * @throw UnableToDecodeToken
      */
     public function __invoke(string $token): Plain
     {
         try {
             $tokenDecoded = $this->parser->parse($token);
 
             if ($tokenDecoded->isExpired(new DateTimeImmutable())) {
-                throw new Exception('Token expired');
+                throw TokenExpired::create();
             }
 
             if (! ($tokenDecoded instanceof Plain)) {
-                throw new Exception('Token not signed');
+                throw TokenNotSigned::create();
             }
         } catch (Throwable $exception) {
-            $this->logger->warning($exception->getMessage(), [$token]);
+            $this->logger->warning($exception->getMessage(), ['token' => $token]);
 
-            throw $exception;
+            throw UnableToDecodeToken::create($exception);
         }
 
         return $tokenDecoded;

src/FetchToken.php

@@ -11,6 +11,9 @@
 use function is_string;
 use function preg_match;
 
+/**
+ * @internal
+ */
 final class FetchToken
 {
     public function __construct(

src/JwtAuthentication.php

@@ -14,7 +14,6 @@
 use Psr\Log\LoggerInterface;
 use Psr\Log\NullLogger;
 use RuntimeException;
-use Throwable;
 
 use function in_array;
 use function sprintf;
@@ -52,7 +51,7 @@ public function process(ServerRequestInterface $request, RequestHandlerInterface
 
         try {
             $jwtDecodedToken = $this->decodeToken->__invoke($token);
-        } catch (Throwable) {
+        } catch (UnableToDecodeToken) {
             return $handler->handle($request);
         }
 

src/JwtAuthentificationAcl.php

@@ -25,7 +25,7 @@ public function __construct(
 
     public function process(ServerRequestInterface $request, RequestHandlerInterface $handler): ResponseInterface
     {
-        if ($this->shouldAuthenticate($request) === false) {
+        if (! $this->shouldAuthenticate($request)) {
             return $handler->handle($request);
         }
 

src/TokenExpired.php

@@ -0,0 +1,15 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Tuupola\Middleware;
+
+use RuntimeException;
+
+class TokenExpired extends RuntimeException
+{
+    public static function create(): self
+    {
+        return new self('Token expired');
+    }
+}

src/TokenNotSigned.php

@@ -0,0 +1,15 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Tuupola\Middleware;
+
+use RuntimeException;
+
+class TokenNotSigned extends RuntimeException
+{
+    public static function create(): self
+    {
+        return new self('Token not signed');
+    }
+}

src/UnableToDecodeToken.php

@@ -0,0 +1,16 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Tuupola\Middleware;
+
+use RuntimeException;
+use Throwable;
+
+class UnableToDecodeToken extends RuntimeException
+{
+    public static function create(Throwable $previous): self
+    {
+        return new self('Unable to decode token.', previous:  $previous);
+    }
+}

tests/Functional/JwtAuthenticationTest.php

@@ -31,8 +31,8 @@
 use Tuupola\Tests\Middleware\Assets\TestBeforeHandlerHandler;
 
 use function assert;
-use function fopen;
 use function json_encode;
+use function Safe\fopen;
 
 /** @psalm-suppress UnusedClass */
 class JwtAuthenticationTest extends TestCase
@@ -273,7 +273,7 @@ public function testWronParser(): void
         };
 
         $logger = self::createMock(LoggerInterface::class);
-        $logger->expects(self::once())->method('warning')->with('Token not signed', [self::$acmeToken]);
+        $logger->expects(self::once())->method('warning')->with('Token not signed', ['token' => self::$acmeToken]);
 
         $token = self::createMock(Token::class);
         $token->expects(self::once())->method('isExpired')->willReturn(false);
@@ -382,7 +382,7 @@ public function testShouldReturn400WithExpiredToken(): void
         };
 
         $logger = self::createMock(LoggerInterface::class);
-        $logger->expects(self::once())->method('warning')->with('Token expired', [self::$expired]);
+        $logger->expects(self::once())->method('warning')->with('Token expired', ['token' => self::$expired]);
         $logger->expects(self::once())->method('debug')->with('Using token from request header', []);
 
         $option = JwtAuthenticationOption::create(InMemory::base64Encoded('mBC5v1sOKVvbdEitdSBenu59nfNfhwkedkJVNabosTw='));