JS basket redirect on "Redir:" response can fail

[kealanm1]

Hi all,

First time contributing to github so apologies if I missed something basic.

Running a demo store beta 2 on http://gooutdoorireland.com/cc6test/store/ a cc5 - cc6 update running foundation skin. When adding items from the homepage latest products to the basket it is adding items multiple times and sometimes updating the qty of items already in the basket. Have not seen this issue reproduced elsewhere in catalogue view.

[abrookbanks]

Hi kealanm1, thanks for taking the time to contribute this. I believe this was a JS bug which has been fixed. If you can whizz over FTP access (securely) to our sales dept I will pick it up and upgrade your store to the latest build. That should fix it.. if it doesn't I can investigate further.

Is that ok? https://support.cubecart.com/index.php?/Tickets/Submit

Thanks again!

[kealanm1]

Hi Al,

Thats been sent over now to your sales team title is the same name as this
mail.

Was hoping to actually contribute to you guys, will keep my eyes peeled and
send on anything else that crops up. Looks good so far!

Regards

Kealan

On Wed, Jan 21, 2015 at 3:33 PM, Al Brookbanks notifications@github.com
wrote:

Hi kealanm1, thanks for taking the time to contribute this. I believe this
was a JS bug which has been fixed. If you can whizz over FTP access
(securely) to our sales dept I will pick it up and upgrade your store to
the latest build. That should fix it.. if it doesn't I can investigate
further.

Is that ok? https://support.cubecart.com/index.php?/Tickets/Submit

Thanks again!

—
Reply to this email directly or view it on GitHub
#104 (comment).

[abrookbanks]

Great.. on it now.. (Internal ticket with FTP: 101305)

[abrookbanks]

I upgraded the code and database.. Does it work now?

[kealanm1]

Hi Al,

Thats working as expected with the number of items in the basket, however a new issue has now emerged. I am no longer redirected to the product page as I was previously for items with sizes / colours etc. and no error flag is presented to advise item not added to basket. Let me know if this should be raised separately.

K

[abrookbanks]

hmm ok I'll take a look into that. :)

[abrookbanks]

Ok this was a weird one and I can't understand how it hasn't come up in v5.

If product options are required the AJAX should get a response "Redir:http://example.com/...". Your store was adding whitespace before "Redir" like " Redir:http://example.com/...". The resulting JS to get the URL by trimming off the first 6 characters returned a bad URL.

I fixed it by splitting on "Redir:" instead.

This issue is now resolved on http://gooutdoorireland.com/cc6test/store

Many thanks for your speedy assistance!! 👍