Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin CP doesn't check if manual download path is valid #1131

Closed
abrookbanks opened this issue Jun 15, 2016 · 5 comments
Closed

Admin CP doesn't check if manual download path is valid #1131

abrookbanks opened this issue Jun 15, 2016 · 5 comments
Assignees
@abrookbanks
Labels
bug
Milestone
6.1.0

Comments

@abrookbanks
Copy link
Member

No description provided.

@abrookbanks abrookbanks added this to the 6.0.12 milestone Jun 15, 2016
@abrookbanks abrookbanks self-assigned this Jun 15, 2016
@bhsmither
Copy link
Contributor

Please see:
https://forums.cubecart.com/topic/51407-6012-feedback-needed-do-your-digital-urls-work/

@abrookbanks abrookbanks reopened this Jun 21, 2016
@abrookbanks abrookbanks modified the milestones: 6.0.13, 6.0.12 Jun 21, 2016
@bhsmither
Copy link
Contributor

If the Request class is versatile enough, we may be able to use that instead of dedicated code.

@abrookbanks
Copy link
Member Author

True.. or maybe it should only check local paths.

abrookbanks pushed a commit that referenced this issue Aug 9, 2016
#1131 added URL support
a957823
@abrookbanks
Copy link
Member Author

This is using http://php.net/manual/en/function.get-headers.php so ti will be interesting to see how compatible it is. I don't think it supports redirects so URL's must return status code 200 for successful check. Any moved URL won't work.

abrookbanks pushed a commit that referenced this issue Aug 9, 2016
Improved fox for #1131
57c7039
@abrookbanks
Copy link
Member Author

.. Any status code over 400 is now considered a fail. This should be better.

abrookbanks pushed a commit that referenced this issue Aug 9, 2016
Removed remote check for #1131
7974799 
Too slow on page load.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abrookbanks abrookbanks

Labels
bug
Projects
None yet
Milestone
6.1.0
Development

No branches or pull requests
2 participants
@bhsmither @abrookbanks