Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileTree Action Center Bad Behavior #1464

Closed
bhsmither opened this issue Jan 22, 2017 · 9 comments
Closed

FileTree Action Center Bad Behavior #1464

bhsmither opened this issue Jan 22, 2017 · 9 comments
Assignees
Labels
Milestone

Comments

@bhsmither
Copy link
Contributor

https://forums.cubecart.com/topic/52044-613-create-upload-folder-disappeared/

Suggest:
jquery.filetree.min.js:

Near line 77:
From:
a(this).each(function() {
To:
a(this).each(function() { var specific_div = this; // Remember this specific filepicker

Near line 214:
From:
if(!$('#fm-actions').length) {
To:
if(!a(specific_div).parent().find('#fm-actions').length) {
@abrookbanks abrookbanks self-assigned this Jan 24, 2017
@abrookbanks abrookbanks added this to the 5.1.5 milestone Jan 24, 2017
abrookbanks added a commit that referenced this issue Jan 24, 2017
All tests positive. Thank you.
abrookbanks added a commit that referenced this issue Jan 25, 2017
This reverts commit 5794dea.
@abrookbanks abrookbanks reopened this Jan 25, 2017
@abrookbanks
Copy link
Member

Relates to #1463

@Dirty-Butter
Copy link

Isn't this supposed to say 6.1.5 milestone?

@abrookbanks
Copy link
Member

It does I think :) Doesn't matter too much as long as it is open.

@Dirty-Butter
Copy link

I have reverted the code concerning image upload folder until you find a stable fix. So I have commented out the Digital tab filemanager code until this is fixed. That allows me to use the filetree action shaded box on the Image tab consistently.

bhsmither added a commit to bhsmither/v6 that referenced this issue Feb 1, 2017
@abrookbanks
Copy link
Member

Fixed with Brians fantastic pull request. :)

@Dirty-Butter
Copy link

Dirty-Butter commented Feb 3, 2017

Not sure where to comment any more, as there are so many dealing with the filemanager upload box. I've tested yesterday's commit, and all looks ok. BUT when I tried to CHANGE the starred image from one image to another - nothing I tried would save with the star off the existing image. I cannot get it to accept a different primary image.
In case it was some non-standard code I have in other places, I've used stock for filemanager and product files in source and default admin skin. All javascript files are stock.

Using stock ajax.class.php I get this error message:

Invalid argument supplied for foreach() in /home/butter01/public_html/plushtest/classes/ajax.class.php on line 140

@Dirty-Butter
Copy link

Moved to the latest commit, still using stock files for filemanager in class, admin source and template, ajax.class.php, all js files, and product files in source and admin templates. All seems OK - so my issue is some non-stock edit.

@abrookbanks
Copy link
Member

Thanks for letting me know. Hope you get it working how you want.

@Dirty-Butter
Copy link

Dirty-Butter commented Feb 4, 2017

With all stock code in applicable files installed, SAVE works to empty the checkbox in preparation for changing primary image. SAVE&RELOAD does NOT. Sorry this has been such a hassle, but thank you for doing all you can to get this to work properly.

FINALLY - I had missed one line of code without imageset in it. Working correctly on two sites now!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants