Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Google reCaptcha to use new version and remove old unsupported V1 #1546

Closed
havenswift-hosting opened this issue Mar 9, 2017 · 15 comments
Assignees
Milestone

Comments

@havenswift-hosting
Copy link

havenswift-hosting commented Mar 9, 2017

reCaptcha V1 (simply labelled reCAPTCHA in store settings) is no longer supported (as of May 2016) and so should be removed.

"New reCAPTCHA" is known as reCaptcha V2 so would be better if that was renamed to match

Also add newly released "Invisible reCaptcha" as a second choice

Docs here: https://developers.google.com/recaptcha/docs/invisible

@abrookbanks
Copy link
Member

Agreed. I won't be able to update 3rd party skins though. Shopdev skins will stop working I expect.

@havenswift-hosting
Copy link
Author

Good chance to retire shopdev skins then lol 3rd party developers can update their own skins based on changes made

@abrookbanks
Copy link
Member

The integration of invisible recaptca is totally different which is annoying. This will be a headache for customised skins and old ones.

@abrookbanks abrookbanks self-assigned this Mar 9, 2017
@abrookbanks abrookbanks added this to the 6.1.6 milestone Mar 9, 2017
abrookbanks added a commit that referenced this issue Mar 9, 2017
abrookbanks added a commit that referenced this issue Mar 9, 2017
@abrookbanks
Copy link
Member

Note to self.. check WTH is going on here:
https://github.com/cubecart/v6/blob/master/classes/gui.class.php#L704

abrookbanks added a commit that referenced this issue Mar 10, 2017
abrookbanks added a commit that referenced this issue Mar 10, 2017
abrookbanks added a commit that referenced this issue Mar 10, 2017
abrookbanks added a commit that referenced this issue Mar 10, 2017
Issue with register and invisible recaptcha but none of the other
methods or locations!??!?
@abrookbanks
Copy link
Member

Everything works with old and new skins but invisible doesn't work with foundation on registration. can' understand this..

abrookbanks added a commit that referenced this issue Mar 10, 2017
abrookbanks added a commit that referenced this issue Mar 10, 2017
abrookbanks added a commit that referenced this issue Mar 10, 2017
@abrookbanks
Copy link
Member

screen shot 2017-03-10 at 14 53 12

abrookbanks added a commit that referenced this issue Mar 10, 2017
abrookbanks added a commit that referenced this issue Mar 10, 2017
abrookbanks added a commit that referenced this issue Mar 10, 2017
@Dirty-Butter
Copy link

Since it's invisible, is there any way for the admin to check to see if it's actually "there" working? I looked at the waterfall using FireBird and didn't see anything there that I could tell was "it".

@abrookbanks
Copy link
Member

It's not actually invisible. When working a reCaptca logo will show at the bottom right of the screen. Mouse over will expand it out with more info.

@Dirty-Butter
Copy link

Dirty-Butter commented Mar 11, 2017

I didn't realize I had to get a different key for the invisible version. Is that clear in the directions? The lower right popup stated I didn't have the key - but I hadn't noticed it.
Once I did that the logo shows properly.

@abrookbanks
Copy link
Member

I didn't know that. New key seems to work with both though.

@Dirty-Butter
Copy link

I have some plugins/mods that will require code changes to make invisible work with them. I don't suppose there would be an easy way to substitute the code sections for the invisible code for the v2 code portions?

@Dirty-Butter
Copy link

The Top button at the bottom of the page overlaps the ReCaptcha badge. I've now installed this on dirtybutterestates.com, a live site - and I am still being asked to complete the recaptcha task.

@Dirty-Butter
Copy link

I am still being asked to complete the challenge, even on the CC demo store. I have my browser privacy settings set strictly - would that make the invisible "think" I was a bot?

This was working for me back a few commits.

@Dirty-Butter
Copy link

SPAM COMMENTS ABOVE

@cubecart cubecart deleted a comment from rahuldadda Aug 20, 2018
@cubecart cubecart deleted a comment from rahuldadda Aug 20, 2018
@abrookbanks
Copy link
Member

Thanks. I delete and reported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants