Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All errors and warnings should be logged in debug mode #1568

Closed
abrookbanks opened this issue Apr 3, 2017 · 8 comments
Closed

All errors and warnings should be logged in debug mode #1568

abrookbanks opened this issue Apr 3, 2017 · 8 comments
Assignees
Labels
Milestone

Comments

@abrookbanks
Copy link
Member

As above. They are not logged otherwise.

@abrookbanks abrookbanks added the bug label Apr 3, 2017
@abrookbanks abrookbanks added this to the 6.1.6 milestone Apr 3, 2017
@abrookbanks abrookbanks self-assigned this Apr 3, 2017
@Dirty-Butter
Copy link

WOW! Lots of errors in the logs now. Do they MEAN anything? Everything is working correctly AFAIK.

@abrookbanks
Copy link
Member Author

Warnings and notices are not important 99.9% of the time. CubeCart uses trigger_error which won't be logged until debug mode is on now.

@abrookbanks
Copy link
Member Author

Essentially this could be useful.

@Dirty-Butter
Copy link

Would it be possible to toggle viewing the Notices vs Warnings? - kind of like the Customers/Bots choice?

@abrookbanks
Copy link
Member Author

Yes that would be a useful improvement.

abrookbanks added a commit that referenced this issue Apr 7, 2017
@Dirty-Butter
Copy link

I'm on today's commit on our test site. Is this something that needs to be addressed as a problem with my install or a problem in the code?

Today, 04/07/2017 3:47PM 	[Warning] /home/butter01/public_html/XXX/classes/cache/cache.class.php:162 - unlink(/home/butter01/public_html/XXX/cache/skin) [function.unlink.php]: Is a directory

@abrookbanks
Copy link
Member Author

Hi Rosemary,

I don't think that's a problem. :)

@Dirty-Butter
Copy link

ok :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants