Better Testing XML Content

[bhsmither]

In Language->cloneModuleLanguage(), PHP's simplexml_load_file() could return a false or something that looks like false.

Suggest:

if(file_exists($from) && !file_exists($to) && ($content = simplexml_load_file($from)) !== false) {
  if(!isset($content->group) && !isset($content->group[0]->attributes()->name)) return false;

So, additionally, if making an object from the file fails, don't do anything.

If a group does not exist, then it matters not if a string node exists. Testing for a string is probably not what we want to verify anyway. The file is out of compliance with the expected schema.

If group does exist, then we can make the next test to see if there is a name. Otherwise, $content->group[0] is null and calling attributes() on null returns a Fatal Error.

Might want to wrap this in a try/catch block.

Also, it seems to me that only group[0] is processed. That might comply with Language version 1.0 schema, but not with Language version 2.0 schema.

[abrookbanks]

Works well. Thank you.