Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image sprite_flags is 404 #1933

Closed
bhsmither opened this issue Apr 10, 2018 · 4 comments
Closed

Image sprite_flags is 404 #1933

bhsmither opened this issue Apr 10, 2018 · 4 comments
Assignees
Labels
Milestone

Comments

@bhsmither
Copy link
Contributor

bhsmither commented Apr 10, 2018

CC620b1

Watching the Network traffic, I see that the request for the image is 404.

In /foundation/css/cubecart.css, there is:

span.flag
background:url(../images/sprite_flags.png)

The browser wants to fetch /images/sprite_flags.png, but the image is not at that absolute root-based folder.

Working on the assumption that the path should be in quotes, I edited the cubecart.css file.

Question 1: How to force CC620 to rebuild the /cache/css.foundation_YYYYMMDDHHMMSS.css?

Manually deleting it made it disappear forever.

@bhsmither
Copy link
Contributor Author

Managed to force a rebuild by also manually deleting css.foundation.css.cache.

@bhsmither
Copy link
Contributor Author

The image file sprite_flags.png is still 404 because the browser wants to load from /images/.

This makes sense because css.foundation_YYMMDDHHMMSS.css is not in the skin folder.

Thus, either the minifier is skipping over some CSS url values (rewriting to what?), or this becomes a RPITA having to recode CSS rules to data:base64 images.

@abrookbanks
Copy link
Member

Is an inline image a PITA? Thanks for this bug report though. I might be able to find and replace ../images/ dynamically.

@abrookbanks
Copy link
Member

Fixed up. Thanks Brian!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants