-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug - Sale Products & Quantity Pricing for Group Memberships #2080
Comments
based on your description. it's working correctly. both the price and sale price are customer group specific. in your example you've only mentioned setting a sale price at the retail group. you need to configure everything at each group level. |
Is that right? So why does it display Retail Pricing Group (Retail Price) if I have no Retail Price set for a Group? Therefore this is the BUG and should not display products for Customer Groups if Retail Price has not been set for their Group. BUT understandably it does not work this way as your method of configuring at each level would be tedious. If no Retail Price is entered in a Membership Group it defaults to Retail Price set in Retail Pricing Group. The same should apply for Sale Price and Discounts. Please follow steps in 1st post up to "Now login as a Customer that has a Membership Group associated. The Product retail price and sale price display correctly everywhere except it no longer display in the "On Sale" box in RHS. Bug - this should still display here." The Product display in "On Sale" page but no longer is displayed in "On Sale" box in RHS which it was before Customer Login. So is the Product On Sale or not? |
Unless superseded by entering values (Retail Price and Sale Price) by setting these for Groups it defaults to these for Retail Pricing, this part work correctly. It should do the same for Quantity Pricing. Much simpler, less tedious and less db resources than configuring each group |
not displaying products because you've not set a price is different, that's a security model thing. (note, I've a security module that can do this for you available on the marketplace). The prices are designed to work "per group", and yes, it's tedious if you have many groups. It doesn't waterfall in the way you are describing. when you say "if no retail price is entered it defaults to the retail price", is correct. having no price defined is invalid, so it always needs a price.. in which case it will clone the retail price on save. NULL price is invalid. this is the initial price, which gets defined at that group level, it is not "linked" to the retail price, it's an initial value. your expecting waterfall logic and it doesn't work in this way. |
"Waterfall logic" and a "security model thing", I'll explain logic and where is the "security model thing?". Why do I need a plugin for what is technically a BUG. I get different outcomes on how products are created and edited for Groups which affect how these are displayed. I will go through each (I will assume you have min 2 Groups set up and a Customer associated to a Group). Goto Add Products (for now leave status checked when creating Products in Steps below)
The 1st question I ask is why does it only clone on Edit and not Add if it is to clone 0.00 values?
The 3rd question is identical to 1st question?
The 5th question is the same as the 4th.
The 6th question - Why clone at all??? My previous 5 questions are now redundant. It should only add to pricing_group the Group/s where Retail Price AND/OR Sale Price have been added. This eliminates 100's if not 1000's of obsolete (useless) entries (Total Groups x Total Products), Simply if no entry exist for a Group in pricing_group it defaults to Retail Pricing. Currently there is a Bug with how "On Sale" products are displayed in RHS box. My recommended method has no Bugs on how these are displayed whilst also saving on resources and having a uniform outcome for Product Pricing for groups whether added or edited. Now we have a global default unless superseded. The last thing remaining is to add a Global checkbox under Retail Pricing. If checked it delete any entries for all Groups for the Product from pricing_groups table on Save. Now it uses the prices from inventory table. Please test until your hearts content, there are no bugs and method works correctly (display correctly in front end, everywhere for both logged out and logged in Customers with/without a Group and with what I can see no "security model thing" I won't go into the virtues of Quantity pricing, It is the addition of 1 if/else statement as outlined in my first post. Sorry about the number of edits as i want to describe it correctly. |
Looks like this can be closed. |
I use Customer Memberships, when I go to Admin -> Products (select a product) -> Pricing the dropdown lists Retail Pricing followed by any Group Memberships.
For now I leave it on Retail Pricing and enter a value in Retail Price and Save. On Save it updates prices for product in inventory table and creates a record in pricing_group table for each of the Membership Groups for the Product.
Now in Product (Retail Pricing) add a value for Sale Price and Save.
Goto frontend - The Product retail price and sale price display correctly everywhere.
Now login as a Customer that has a Membership Group associated. The Product retail price and sale price display correctly everywhere except it no longer display in the "On Sale" box in RHS. Bug - this should still display here.
Next let's do the same with Quantity Pricing. Under Retail Pricing enter Quantity Pricing and Save. On save it creates record/s for Product (product_id) in pricing_quantity table with group_id == 0
Goto Frontend (Logged Out). The Product display Quantity Prices correctly.
Now login as a Customer that has a Membership Group associated, Bug - the Product does not display Quantity Pricing, it should display it.
If customer_membership.group_id== pricing_quantity.group_id it display Quantity Pricing for the Membership Group elseif group_id == 0 it display Quantity Pricing (Retail Pricing)
Retail Pricing - Retail Price, Sale Price and Quantity Price should be default values unless superseded by Selecting a different Membership in Product Pricing
The text was updated successfully, but these errors were encountered: