Gift Cards Cannot Set Image

[bhsmither]

CC622 and probably later.

Selecting an image to assign to a Gift Card fails to be processed on POST.

In settings.giftcerts.php, there is:

<input name="image" id="uploader" type="file">

A POST with a type="file" will cause PHP to create the superglobal $_FILES.

If no actual image is in the POST payload, the resulting array is:

$_FILES => Array
(
    [image] => Array
        (
            [name] => 
            [type] => 
            [tmp_name] => 
            [error] => 4  // UPLOAD_ERR_NO_FILE
            [size] => 0
        )

In settings.giftcertificates.inc.php, near line 21, a call is made to FileManager->upload(). Then, FileManager->upload() tests for a non-empty $_FILES - which evaluates to true and finally returns true.

PHP complains about the argument in the following foreach().

Suggest similar to categories.index.inc.php:

if (($uploaded = $filemanager->upload()) !== false && is_array($uploaded)) {

Also, the File Picker javascript does not switch to the 1.jpg for the assigned image.

Also, the image preview does not work.