Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coupon and GC Codes to be UTF-8 Capable #2519

Closed
bhsmither opened this issue May 6, 2020 · 1 comment
Closed

Coupon and GC Codes to be UTF-8 Capable #2519

bhsmither opened this issue May 6, 2020 · 1 comment
Assignees
@abrookbanks
Labels
bug
Milestone
6.4.0-b1

Comments

@bhsmither
Copy link
Contributor

Feature Request:

For our non-English speaking users, request that GC and Coupon codes using UTF-8 characters survive the preg_replace() near line 55 in products.coupons.inc.php.

(I have not tested this.)

See:
https://www.php.net/manual/en/function.preg-replace.php#106981
https://www.php.net/manual/en/reference.pcre.pattern.modifiers.php#103348
@abrookbanks abrookbanks self-assigned this Aug 11, 2020
@abrookbanks abrookbanks added this to the 6.2.10 milestone Aug 11, 2020
abrookbanks added a commit that referenced this issue Aug 11, 2020
@abrookbanks
#2519 - Added unicode support
c18e2ca
abrookbanks added a commit that referenced this issue Aug 11, 2020
@abrookbanks
#2519 - Front end validation
991458e
@abrookbanks
Copy link
Member

Thanks Brian.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abrookbanks abrookbanks

Labels
bug
Projects
None yet
Milestone
6.4.0-b1
Development

No branches or pull requests
2 participants
@bhsmither @abrookbanks