New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CubeCart to Log 404s #3304
Comments
This is ridiculously useful. |
Please also update maintenance.index.inc.php, |
Thanks I totally forgot about that!! |
Please note that the table name needs to be lower-case. |
Toggle could automate when redirect is added too. Should query strings be removed? |
I vote to not include them as they do not further define what the product's Search Engines tab, "Custom SEO URL Path" value is. However, in Store Settings, Search Engines tab, "Add category to product URL path?" seems to imply something might happen in the meta data. (I don't see any category names anywhere, so will have to trace this out.) |
Please check spelling/grammar for the new string From: To: (Maybe "...marked as done, but the redirect is not valid.') |
Thanks. I hadn't got around to what I call the polish stage yet but thanks
I appreciate this because my spelling and grammar is horrendous.
…On Thu, 22 Jun 2023, 18:00 Brian Smither, ***@***.***> wrote:
Please check spelling/grammar for the new string 404_desc.
From:
The table below shows 404 (not found) request URL's form the last 90 days.
These can be fixed by creating a redirect to appropriate area of your store
in the "Redirects" tab. Once done it's possible to toggle it's staus in the
"Done" column with a click. A warning triangle may show next to a 404 that
still isn't working but marked as done.
To:
The table below shows 404 (not found) page requests for the last 90 days.
These can be fixed by creating a redirect to the current, correct page in
the "Redirects" tab. Once created, it is possible to toggle it's status in
the "Done" column. A warning triangle may show for a 404 that is marked as
done, but [two or three words that say exactly what it is that] isn't
working.
—
Reply to this email directly, view it on GitHub
<#3304 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABCPWYZWKUHL4QBGP6FG5EDXMR2ZFANCNFSM6AAAAAAYHJL4TU>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
If correcting the wording and grammar, it might be a smart move to correct the apostrophe error at the same time. There is only one meaning of "it's" - "it is" |
Thanks guys. |
This seems to be working really well. |
Warning triangle needs a reset click. |
What about pentest URIs? Those page requests that are looking for exploitable apps, such as (whatever this is):
Obviously, there isn't going to be a redirect. So, other than waiting 90 days for this to roll off, there should be a way to delete this log entry on demand. So, perhaps a Delete icon in the 'action' (right-most) column. Suggest repurposing the ID column to be a checkbox with "Check All" and "With Checked..." selector at the bottom of the table. Perhaps also to have an Edit or Tools icon in the 'action' column that transfers the URI value to the 'ready-to-add' row of the Redirects table. |
We need an ignored column.
…On Fri, 23 Jun 2023, 17:18 Brian Smither, ***@***.***> wrote:
The table below shows 404 (not found) page requests for the last 90 days.
These can be fixed by creating a redirect to the current, correct page in
the "Redirects" tab. Once created, it is possible to toggle its status in
the "Done" column. A warning triangle may show for a 404 that is marked as
done, but subsequent page requests have continued to fail.
What about pentest URIs? Those page requests that are looking for
exploitable apps, such as (whatever this is):
/private/api/v1/service/premaster
Obviously, there isn't going to be a redirect.
So, other than waiting 90 days for this to roll off, there should be a way
to delete this log entry on demand. So, perhaps a Delete icon in the
'action' (right-most) column.
Suggest repurposing the ID column to be a checkbox with "Check All" and
"With Checked..." selector at the bottom of the table.
Perhaps also to have an Edit or Tools icon in the 'action' column that
transfers the URI value to the 'ready-to-add' row of the Redirects table.
—
Reply to this email directly, view it on GitHub
<#3304 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABCPWY4RX643FW3ISHL54CLXMW6WHANCNFSM6AAAAAAYHJL4TU>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
There may be the case that a page request is made using a seo path that no longer exists, but has yet to come to the attention of the admin that adding a redirect is warranted.
Feature Request: Add the means to log the seo path submitted but failed (code execution passing through
Cubecart->_404()
). Then, in admin, Redirects, show that log (above, below, on a second tab, whatever) to facilitate the admin in creating appropriate redirects. (The log listing to have a checkbox to mark the row as having been dealt with. Also, keep the table trimmed to X number of days.)The text was updated successfully, but these errors were encountered: