Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CubeCart to Log 404s #3304

Closed
bhsmither opened this issue May 19, 2023 · 16 comments
Closed

CubeCart to Log 404s #3304

bhsmither opened this issue May 19, 2023 · 16 comments
Assignees
Milestone

Comments

@bhsmither
Copy link
Contributor

There may be the case that a page request is made using a seo path that no longer exists, but has yet to come to the attention of the admin that adding a redirect is warranted.

Feature Request: Add the means to log the seo path submitted but failed (code execution passing through Cubecart->_404()). Then, in admin, Redirects, show that log (above, below, on a second tab, whatever) to facilitate the admin in creating appropriate redirects. (The log listing to have a checkbox to mark the row as having been dealt with. Also, keep the table trimmed to X number of days.)

@abrookbanks abrookbanks self-assigned this Jun 21, 2023
@abrookbanks abrookbanks added this to the 6.5.2 milestone Jun 21, 2023
@abrookbanks
Copy link
Member

This is ridiculously useful.

abrookbanks added a commit that referenced this issue Jun 21, 2023
@abrookbanks abrookbanks pinned this issue Jun 21, 2023
abrookbanks added a commit that referenced this issue Jun 21, 2023
abrookbanks added a commit that referenced this issue Jun 21, 2023
@bhsmither
Copy link
Contributor Author

Please also update maintenance.index.inc.php, $index_map (line 618).

abrookbanks added a commit that referenced this issue Jun 21, 2023
@abrookbanks
Copy link
Member

Thanks I totally forgot about that!!

@bhsmither
Copy link
Contributor Author

bhsmither commented Jun 21, 2023

Please note that the table name needs to be lower-case.

@abrookbanks
Copy link
Member

Screenshot 2023-06-22 at 14 23 48

@abrookbanks
Copy link
Member

abrookbanks commented Jun 22, 2023

Toggle could automate when redirect is added too.

Should query strings be removed?

@bhsmither
Copy link
Contributor Author

I vote to not include them as they do not further define what the product's Search Engines tab, "Custom SEO URL Path" value is.

However, in Store Settings, Search Engines tab, "Add category to product URL path?" seems to imply something might happen in the meta data. (I don't see any category names anywhere, so will have to trace this out.)

@bhsmither
Copy link
Contributor Author

bhsmither commented Jun 22, 2023

Please check spelling/grammar for the new string 404_desc.

From:
The table below shows 404 (not found) request URL's form the last 90 days. These can be fixed by creating a redirect to appropriate area of your store in the "Redirects" tab. Once done it's possible to toggle it's staus in the "Done" column with a click. A warning triangle may show next to a 404 that still isn't working but marked as done.

To:
The table below shows 404 (not found) page requests for the last 90 days. These can be fixed by creating a redirect to the current, correct page in the "Redirects" tab. Once created, it is possible to toggle it's status in the "Done" column. A warning triangle may show for a 404 that is marked as done, but [two or three words that say exactly what it is that] isn't working.

(Maybe "...marked as done, but the redirect is not valid.')

@abrookbanks
Copy link
Member

abrookbanks commented Jun 22, 2023 via email

@hairy-dog
Copy link

If correcting the wording and grammar, it might be a smart move to correct the apostrophe error at the same time. There is only one meaning of "it's" - "it is"

abrookbanks added a commit that referenced this issue Jun 23, 2023
abrookbanks added a commit that referenced this issue Jun 23, 2023
@abrookbanks
Copy link
Member

Thanks guys.

@abrookbanks
Copy link
Member

This seems to be working really well.

@abrookbanks
Copy link
Member

Warning triangle needs a reset click.

@bhsmither
Copy link
Contributor Author

The table below shows 404 (not found) page requests for the last 90 days. These can be fixed by creating a redirect to the current, correct page in the "Redirects" tab. Once created, it is possible to toggle its status in the "Done" column. A warning triangle may show for a 404 that is marked as done, but subsequent page requests have continued to fail.

What about pentest URIs? Those page requests that are looking for exploitable apps, such as (whatever this is):

/private/api/v1/service/premaster

Obviously, there isn't going to be a redirect.

So, other than waiting 90 days for this to roll off, there should be a way to delete this log entry on demand. So, perhaps a Delete icon in the 'action' (right-most) column.

Suggest repurposing the ID column to be a checkbox with "Check All" and "With Checked..." selector at the bottom of the table.

Perhaps also to have an Edit or Tools icon in the 'action' column that transfers the URI value to the 'ready-to-add' row of the Redirects table.

@abrookbanks
Copy link
Member

abrookbanks commented Jun 23, 2023 via email

abrookbanks added a commit that referenced this issue Jun 26, 2023
@abrookbanks
Copy link
Member

Screenshot 2023-06-26 at 09 29 01

@abrookbanks abrookbanks unpinned this issue Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants