Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8 Warning #3397

Closed
bhsmither opened this issue Oct 2, 2023 · 4 comments
Closed

PHP 8 Warning #3397

bhsmither opened this issue Oct 2, 2023 · 4 comments
Assignees
@abrookbanks
Labels
bug
Milestone
6.5.3

Comments

@bhsmither
Copy link
Contributor

In orders.index.inc.php line 307, when the admin is reviewing an order where that order may have been administratively created, there may not be any serialized data held in CubeCart_order_summary, 'basket' column.

If not, $basket_array will be false.
@abrookbanks abrookbanks self-assigned this Oct 3, 2023
@abrookbanks abrookbanks added the bug label Oct 3, 2023
@abrookbanks abrookbanks added this to the 6.5.3 milestone Oct 3, 2023
abrookbanks added a commit that referenced this issue Oct 3, 2023
@abrookbanks
#3397 - Ensure $basket_array is array
15b7393
@abrookbanks
Copy link
Member

Thanks.

@bhsmither
Copy link
Contributor Author

Then, statements that want to use $basket_array should prepare for unknown array keys:

$basket_array['weight'] ?? 0

@abrookbanks abrookbanks reopened this Oct 3, 2023
@abrookbanks
Copy link
Member

Good point!

abrookbanks added a commit that referenced this issue Oct 4, 2023
@abrookbanks
#3397 - $basket_array['weight'] ?? 0
28c0dd8
@abrookbanks
Copy link
Member

Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abrookbanks abrookbanks

Labels
bug
Projects
None yet
Milestone
6.5.3
Development

No branches or pull requests
2 participants
@bhsmither @abrookbanks