Product & Category Description to be Parsed by Smarty

[bhsmither]

Feature Request:

On the admin, Product, Add/Edit, Description tab, add a checkbox that will cause to send the content through Smarty prior to displaying on the storefront.

products.index.php:

   <div id="description" class="tab_content">
      <fieldset>
         <h3>{$LANG.common.description}</h3>
         <div>
            <label for="product_parse">{$LANG.catalogue.product_parse}</label><span><input type="hidden" name="product_parse" id="product_parse" class="toggle" value="{$PRODUCT.product_parse}"></span>
         </div>
         <textarea name="description" class="textbox fck">{if $PRODUCT.description}{htmlentities($PRODUCT.description, ENT_QUOTES, 'UTF-8', true)}{/if}</textarea>
         <br>
         <h3>{$LANG.common.description_short} {$LANG.common.optional}</h3>
         <textarea name="description_short" id="description_short" class="textbox fck">{if $PRODUCT.description_short}{htmlentities($PRODUCT.description_short, ENT_QUOTES, 'UTF-8', true)}{/if}</textarea>
      </fieldset>
   </div>

catalogue.class.php:

                $GLOBALS['language']->translateProduct($product);
                $product['description'] = ($product['product_parse']==1) ? $GLOBALS['smarty']->fetch('string:'.$product['description']) : $product['description'];

language.xml:

<group name="catalogue">
  <string name="product_parse" introduced="6.5.4"><![CDATA[Parse Smarty Tags in Description]]></string>

Database table CubeCart_inventory: add column 'product_parse', TINYINT:1 UNSIGNED NULL DEFAULT 0

[abrookbanks]

{$smarty.now|date_format:"%D"}

corrupts to

<p>0--&gt;</p>

[bhsmither]

I cannot reproduce your corruption.

[abrookbanks]

Hmm. Does this work for you?

Screen.Recording.2024-03-13.at.16.46.54.mp4

[bhsmither]

That does not happen for me.

[abrookbanks]

Which browser? I wonder if it's my version of Chrome.

[bhsmither]

Latest Firefox.

[abrookbanks]

Hmm. Same fault in Safari. I'll try the demo store...

[bhsmither]

Editing email templates should have the same problem, no?

[abrookbanks]

It works on the demo store https://demo.cubecart.com/cc6

Something must be different in my development build....

[bhsmither]

Might have to try the Store Settings, Copyright.

[abrookbanks]

Changing the config file from;

config.extraPlugins = 'showprotected,emoji,textmatch,autocomplete,textwatcher';

to this fixes it. So one of the new plugins for emoji is breaking it.

config.extraPlugins = 'showprotected';

[abrookbanks]

It works with one instance of ckeditor but not two. We have a description and short description.

[abrookbanks]

This is a real headache

[abrookbanks]

I think there is a compatibility issue with the showprotected plug-in and the latest version of ckeditor. It works when there is one instance of CKE but not two. It's far to advanced for me to debug and the code is minified.

Maybe we can revisit this later.

[bhsmither]

It works with one instance of ckeditor but not two. We have a description and short description.

Did not the 'short_description' always have the showprotected effect? Honestly, I never checked because I never planned to parse the short description.

[abrookbanks]

The main config loads showprotected into every instance of ckeditor. The fault lied when there are more than one on a page.

Maybe there is a work around..

Screen.Recording.2024-03-14.at.16.53.16.mp4

[bhsmither]

Again, not able to replicate your observation.

[abrookbanks]

Are you using the latest GitHub build?

…

On Thu, 14 Mar 2024, 18:03 Brian Smither, ***@***.***> wrote: Again, not able to replicate your observation. — Reply to this email directly, view it on GitHub <#3427 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABCPWY4IBF5YLR2ABHLYSG3YYHRATAVCNFSM6AAAAAA7J2M7U6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJYGAZTOMZUG4> . You are receiving this because you modified the open/close state.Message ID: ***@***.***>

[bhsmither]

CC653. I also played with the CC demo. I have no issues there.

A key difference I see is that CC654 is expected to be using CKEditor 4.22.1, where CC653 is using CKEditor 4.12.1.

Did you not find that the extraPlugins, other than showprotected, was causing problems?

I will fetch CKEditor 4.22.1 and play with it.

[bhsmither]

Using the largest pre-built package of CKEditor4.22.1, the observations mentions earlier are confirmed.

However, my first experiment is on the Store Settings, Copyright and Offline tabs.

Further experiments show that editing config.js as follows:

// config.protectedSource.push(/{\S*?.*?\S}/g);

does not corrupt the editor contents.

Restoring protectedSource but commenting extraPlugins (with only showprotected listed) returns the corruption.

So, this suggests that there is a fault with protectedSource or the REGEX argument, and no fault with showprotected.

[bhsmither]

There are differences in the CKEditor core file htmldataprocessor.js, function protectSource(), comparing 4.12.1 vs. 4.22.1.

[bhsmither]

Analysis so far suggests (actually, a guess) that every instance of the editor that gets spun up per page request reads and implements the settings in config.js. Which is to say, config.protectedSource.push happens that many times.

In htmldataprocessor.js, function protectSource(), these regexes are processed.

My wild guess is that, now in this version, is: replacing {word} with {cke_temp} then follows that braces are found again. If this is the case, I tried to de-dupe the array, and tried to pop off the last element. Neither tactic seemed to affect the array of regexes.

[bhsmither]

The following is my fix. Test extensively!

In config.js:
Was:
config.protectedSource.push(/{\S*?.*?\S}/g);
Now:
config.protectedSource = [/{\S*?.*?\S}/g];

Not pushing it onto the array. Just making it that array.

[abrookbanks]

That works and it works well! Are you an actual genius Brian? Seems very much like you are.

[abrookbanks]

[bhsmither]

Are you an actual genius Brian?

Yes. Yes, I am.

[abrookbanks]

I did think so. It's official now.

…

On Fri, 15 Mar 2024, 15:19 Brian Smither, ***@***.***> wrote: Are you an actual genius Brian? Yes. Yes, I am. — Reply to this email directly, view it on GitHub <#3427 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABCPWY25F4IXCFJOVSLF25LYYMGPNAVCNFSM6AAAAAA7J2M7U6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJZHA4TCMJUGM> . You are receiving this because you were assigned.Message ID: ***@***.***>