Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discrepancy Github vs Download #962

Closed
bhsmither opened this issue Jan 15, 2016 · 6 comments
Closed

Discrepancy Github vs Download #962

bhsmither opened this issue Jan 15, 2016 · 6 comments
Assignees
Labels
Milestone

Comments

@bhsmither
Copy link
Contributor

In the CC609 download, /admin/sources/dashboard.index.inc.php, a diff file against CC608 shows:

@@ +255,7 -255,6 @@
  $request->cache(true);
  $request->skiplog(true);
  $request->setMethod('post');
-   $request->setData('Null');

  if (($response = $request->send()) !== false) {
    try {

The indicated statement is not present in CC609, but Github says it is still there.

@bhsmither
Copy link
Contributor Author

Request->_request_body needs to be set to something, because Request->send() will do nothing if Request->_request_body is empty.

@bhsmither
Copy link
Contributor Author

Same for maintenance.index.inc.php, line 169 (in CC608 - removed in CC609).

I am not seeing any changes in CC609 (that I downloaded) that would make Request->_request_body be non-empty.

@bhsmither
Copy link
Contributor Author

And various other files.

@abrookbanks
Copy link
Member

Relates to #947

abrookbanks pushed a commit that referenced this issue Jan 18, 2016
@abrookbanks abrookbanks modified the milestone: 6.1.0 Jan 18, 2016
@abrookbanks
Copy link
Member

Fixed with bc56cc4

@abrookbanks abrookbanks added this to the 6.0.10 milestone Jan 18, 2016
@abrookbanks abrookbanks self-assigned this Jan 18, 2016
@abrookbanks
Copy link
Member

Thanks Brian.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants