Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolves issue #976 #1144

Merged
merged 2 commits into from
Sep 20, 2016
Merged

Resolves issue #976 #1144

merged 2 commits into from
Sep 20, 2016

Commits on Sep 16, 2016

  1. Featured products now controllable 

    Allows store owners to specify exactly which products, if any, should be featured, rather than pulling a completely random product.
    @briansandall
    briansandall committed Sep 16, 2016
    Configuration menu
    Copy the full SHA
    3d78c95 View commit details
    Browse the repository at this point in the history

  2. A more efficient means of selecting the random featured product 

    Works by selecting all product IDs that are featured and then choosing randomly from within that result set, completely removing recursive calls yet getting a valid result on the first try every time in most cases.

Since only the product IDs are fetched, memory overhead should be minimal even in the unlikely scenario that a store has thousands of featured products.

Efficiency could be optimized even further with an index on the `featured` column.
    @briansandall
    briansandall committed Sep 16, 2016
    Configuration menu
    Copy the full SHA
    3c4a7dc View commit details
    Browse the repository at this point in the history