New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug with AMD RX series gpus and "Flat lit toon shader" #27
Comments
Also, it seems to ONLY happen in VR |
Neither Cubed nor I have an AMD RX GPU to debug this issue with; so this is unlikely to get fixed. If someone with an affected card wants to fix it they can do so and submit a pull request. We'll take a look and merge it in as long as it doesn't break anything else. As far as we can guess this is an issue with the geometry shader stage not working correctly on the AMD RX GPUs when Single Pass Stereo is enabled. The shader uses the geometry shader stage to generate the outline without doing two draw passes which would double the CPU rendering cost. The shadows still work because the shadow caster pass does not include the outline so it doesn't use the geometry shader stage. |
Qbd or TCL.
Id be willing to work with you to figure out a solution. The only reason I
believe this is the shaders fault is because VRchat does not contain errors
when models go invisible. And I don't think it's AMD because regardless of
what driver we use, nothing works. I think it's the shader because it USED
to work fine, would it be possible to get a previous version of the shader
to find a difference or something that wouldn't cause the problem in an
older version, but is in a newer version?
Thanks, Noah.
…On Jan 7, 2018 2:15 PM, "TCL987" ***@***.***> wrote:
Neither Cubed nor I have an AMD RX GPU to debug this issue with; so this
is unlikely to get fixed. If someone with an affected card wants to fix it
they can do so and submit a pull request. We'll take a look and merge it in
as long as it doesn't break anything else.
As far as we can guess this is an issue with the geometry shader stage not
working correctly on the AMD RX GPUs. The shader uses the geometry shader
stage to generate the outline without doing two draw passes which would
double the CPU rendering cost. The shadows still work because the shadow
caster pass does not include the outline so it doesn't use the geometry
shader stage.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#27 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AhdjYRVzAxd3eeMLBGjm7hWuftqpPbd3ks5tIRfGgaJpZM4RPbFB>
.
|
I'd also be willing to help if there's anything I can do outside of coding. |
@HammondParis The shader did not always use a geometry shader; the geometry shader replaced the separate outline pass to improve performance back at the end of September. However because shaders are uploaded separately with each avatar updates take a while to propagate as people have to update their shaders and re-upload their avatars. So the issue may not have become apparent right away. |
TCL,
Okay, I could see why the issue would slowly reach into the game with that
theory. Would I be able to get a version of the shader that used the
outline pass instead of the geometry to confirm it's possibly that? It
would help narrow down the issue and we may be able to contact AMD. I'm not
very knowledgeable about the mechanics of the shader, but any information
helps to find the solution.
…On Jan 7, 2018 4:06 PM, "TCL987" ***@***.***> wrote:
@HammondParis <https://github.com/hammondparis> The shader did not always
use a geometry shader; the geometry shader replaced the separate outline
pass to improve performance back at the end of September. However because
shaders are uploaded separately with each avatar updates take a while to
propagate as people have to update their shaders and re-upload their
avatars. So the issue may not have become apparent right away.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#27 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AhdjYSFRwj_6ipF7-mSbxXLOIe7rl1ceks5tITHNgaJpZM4RPbFB>
.
|
I was messing around with it a few minutes ago. It does it in nonVR as well. |
I would be very grateful if anyone can find a fix for this, I'd even be willing to pay for a fix. Really sucks that one of the most anticipated VR games for me is the only one that does not work correctly. I have an RX480. I can also confirm that this problem happens inside and outside of VR and only with the flat-lit toon shader, which most people use |
Happens with me too, I also have an RX480. Sucks when you can't even see 70% of people since most use flat-lit toon. I can't find any shaders that look as nice as flat-lit toon either. It'd be nice to have the older version that didn't use a geometry shader so I could at least see my own avatars. |
I know right, im running on a gtx 580 and i cant afford changing Gpu atm and i want to play this fun and wonderful game but cause of this bug i am horribly depressed and disapointed with this problem, so i hope this problem gets resolved soon |
Guys, This issue tracker is not meant for begging for a fix. The shader developers are well aware of the issue and will fix it if/when they gain access to an affected GPU-- as in, they have one physically available to them for testing. If you are skilled with writing shaders and have an affected GPU, please write a fix and submit a pull request. Asking for the old version will not be useful because that would require that every avatar creator swap to that older version. |
CD,
I'm aware that we will not be able to get everyone to swap to an older
version, thats simply impossible. I'm asking for an older version to use as
something to compare to the newer version and find the differences between
the two to pinpoint a little closer on the exact cause of the issue. I
really don't mind finding the issue myself, I just want a stable version
that works to help find a solution.
Noah.
…On Mon, Jan 8, 2018 at 3:00 PM, CD Tupper ***@***.***> wrote:
Guys,
This issue tracker is not meant for begging for a fix. The shader
developers are well aware of the issue and will fix it if/when they gain
access to an affected GPU-- as in, they have one physically available to
them for testing. If you are skilled with writing shaders and have an
affected GPU, please write a fix and submit a pull request.
Asking for the old version will not be useful because that would require
that *every avatar creator swap to that older version.*
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#27 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AhdjYUuzghcTmFlshhLgAlhNH71A-iDYks5tInP7gaJpZM4RPbFB>
.
|
Can anyone help me understand why any VRChat avatars that I apply these shaders to show up in game as the red transparent placeholder man? I dont think I've had any issues with other players avatars either and I've probably seen tons using these shaders. From what I can tell its just the ones I apply it too. I have an R9 390. |
This guy's solution worked for me, if it helps. http://steamcommunity.com/app/438100/discussions/7/1635237606656031878/ |
@Tollyt Thanks for the link and fix! since this appears to be an AMD driver regression, could you fill out an issue report form on their site, and forward any responses to us? I'd love to see the problem fixed for everyone without having to revert their drivers. https://www.amdsurveys.com/se/5A1E27D258D43A88 here's a link to a support form, the support link on the version you posted is dead. |
I have uploaded a new version of the shader with some tweaks to the some compiler pragmas. Could someone that is still on the latest AMD drivers please test the new version and see if the change helped? |
TCL987, I am currently running with an RX 580 |
@TCL987 I tried the new version of the shader with my rx 480 and it doesn't work for me either. I'm also on the latest driver version, which is 17.12.2. Also the models don't load in game and just stay as a red silhouette if you put the rendering mode on opaque. They load if you have it on cutout, just wasn't sure if that was supposed to happen with opaque. |
It does seem to be fixed if you use version 17.1.1, but the screen glitches around like crazy in VR with that version so I still wouldn't say it's playable. |
idk how to see my driver version |
@shrilex Open the app "AMD Radeon Settings", click "updates" in the bottom lleft and it says there. |
but what if im a windows users? |
Anyone have a new link to the fix? The current one is just popping up as an error for me. |
@Hopossum The fix was to revert back to driver version 17.1.1. It works, but it's incredibly glitchy to play in VR with that older version so I really wouldn't call it a viable fix. |
I can confirm the 17.1.1 drivers work on the RX480. Thanks for a solution. Although it makes most VR games worse and causes a lot of flickering / glitches. This is the last time I buy an AMD card. |
I have an RX580, so when I go to download 17.1.1, it automatically reverts it to 17.7. Is there anyway around this? |
if i switch to 17.1.1 can i go back to 17.7 again later? |
This bug appears only with htc vive. Someone plugged in oculus on the same pc, and bug was gone. So apparently its a combination of radeon and vive. Hope this helps to find the source of the bug. |
Also another interesting thing to note - My brother has the EXACT same PC build as I do - Down the to same RAM model, GPU, CPU, everything - And he can see Cubed's Shaders just fine while in VR, whereas I cannot. Is there any way we could figure out how this happens? Like maybe I could find what all his driver versions are and we can figure something out with that? He's running AMD driver 17.3.3 like most people say works, but he gave those drivers to me to use but it still didn't work for me. So if that's the only reason it's working for him, I'll just continue to wait for @cubedparadox to agree to being lent my RX 480 |
If you're installing drivers, run amd clean utility to remove traces then
reinstall the driver. Again, downgrading shouldn't the only option.
…On Tue, Apr 17, 2018, 11:52 AM SlugBug ***@***.***> wrote:
Also another interesting thing to note - My brother has the EXACT same PC
build as I do - Down the to same RAM model, GPU, CPU, everything - And he
can see Cubed's Shaders just fine while in VR, whereas I cannot. Is there
any way we could figure out how this happens? Like maybe I could find what
all his driver versions are and we can figure something out with that? He's
running AMD driver 17.3.3 like most people say works, but he gave those
drivers to me to use but it still didn't work for me. So if that's the only
reason it's working for him, I'll just continue to wait for @cubedparadox
<https://github.com/cubedparadox> to agree to being lent my RX 480
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#27 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADvIyKBxns0cMsb9P9OmlHVBOx3RdP6Fks5tpg_BgaJpZM4RPbFB>
.
|
@SlugBug I'm interested in borrowing hardware, but the next month or so is going to be bad timing for me, I'll be away from my pc and unable to test cards. In the meantime until we find a fix/AMD fixes their drivers, I've released a lite version of my shader, which avoids doing geometry shading altogether by removing outline support. |
I'll give it a test run sometime tomorrow to see if it helps.
…On Wed, Apr 18, 2018, 1:20 AM Nick Benge ***@***.***> wrote:
@SlugBug <https://github.com/SlugBug> I'm interested in borrowing
hardware, but the next month or so is going to be bad timing for me, I'll
be away from my pc and unable to test cards.
In the meantime until we find a fix/AMD fixes their drivers, I've released
a lite version of my shader, which avoids doing geometry shading altogether
by removing outline support.
https://github.com/cubedparadox/Cubeds-Unity-Shaders/releases/tag/0.24
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#27 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADvIyAIBmZAzergBHb_aqAH3RJLtpuo5ks5tps0QgaJpZM4RPbFB>
.
|
@cubedparadox Alright sounds good, just let me know once you've got more free time on your hands :) Thanks for the lite shader btw, I know it won't help anything since all the problem models will still be using the old shaders, but the new options of things like double-sided shaders are great to have! |
So I'm not exactly sure what changed with my system, but wanted to share. Basic system specs: The first time launching the game today had me run into the typical invisible models bug. No surprises, I've had this in the past over several different driver versions. I exited the game and went to the "Gaming" profiles in Adrenalin (Radeon Settings). At first, I removed every setting that was AMD-optimized (Everything either off or "Application Settings"). When I launched the game the second time around the models with Cubed's shader were working for about 10 minutes but I noticed the game would occasionally stutter as though it were loading. After a few of these the models first went shadow-only and then invisible. The next thing I did was enable all of the AMD optimized options, adaptive multisampling, shader cache, anisotropic filtering x16, the whole bit. The next time I loaded the game the models stayed visible during my whole test (about 20 minutes) including swapping between worlds. As I said, not sure if this information is helpful at all, but considering I am using pretty much all of the hardware and software that tends to cause this issue, figured it might be worth mentioning. Disclaimer: The issue isn't "fixed" because it does still happen once in a while, but as I mentioned it tends to only break when the game is stuttering as though having to load something new or refresh. |
I wanted to briefly update, a friend used the the lite version of the shader and it does in fact fix the issue and is fully visible, albeit full-bright due to lack of shadows. The glitch is definitely associated with the part of code that is not included in the lite version. |
AMD update 18.4.1 RX480 maybe be positive for cube shader re-support. I keep walking around and no avatars where gone. Could be many reasons for it, dont know. One anime model was using standard but that could be nothing. Recommend testing different cubed shader versions with this update. |
@ACIIL it seems to be at random (meaning you could go a whole session without anything happening but when reloading it may show signs of it wanting to act up), but some places like the moon or mars still act up regardless of what version you on. |
@ACIIL Unfortunately, I was able to replicate the bug on the latest driver release. The driver does not correct the shader bug. Note, I use a AMD RX 560, so maybe a fix for RX 400 series cards? Might be unstable according to the previous comment, and still might not fully fix the issue. Verdict: Not a solution yet. |
Yeah nope using RX 480 and I can tell you the new driver does not fix the issue. I've tried installing the old driver they say works from jan 2017 "Aev yeah that does not work... Yeah I really want to play and enjoy this game but untill I can see other people this just completely keeps me from playing it |
As someone who has followed this for a while, this bug is a weird one. if
you stick with playing and updates long enough it goes away permanently for
some and not others. And that is on the same card with the same drivers on
same headset. It seams very random.
…On Sat, May 19, 2018 at 9:32 AM, TheLDSmissionary ***@***.***> wrote:
Yeah nope using RX 480 and I can tell you the new driver does not fix the
issue. I've tried installing the old driver they say works from jan 2017
"Aev
From my understanding, this is an issue with the way Cubed's shader
creates the outline on avatars. It's not related to VRChat, it's something
that AMD broke in their drivers (the Jan 2017 AMD driver still works).
There is a recently released version of Cubed's shader that doesn't have
the outline option, which will display correctly for users with AMD GPUs.
Past that, this is not something VRChat can fix on their end."
yeah that does not work...
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#27 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHZVkNbfy6oYeD7TP_YHxMbqXtOIp89gks5t0Cz3gaJpZM4RPbFB>
.
|
Yeah I was very happy when I first played this game, had no issues on my first day, then when I logged in my second day and every time since my avatar has disappeared and most others along with it. Very discouraging |
I'm seeing reports that this is fixed with the latest drivers. Please try updating your drivers to the latest version: Radeon Software Adrenalin Edition 18.5.1, released 5/22/2018. |
I'll give it a try in a bit to see
…On Wed, May 23, 2018, 3:51 PM CD Tupper ***@***.***> wrote:
I'm seeing reports that this is fixed with the latest drivers. Please try
updating your drivers to the latest version:
Radeon Software Adrenalin Edition 18.5.1, released 5/22/2018.
https://support.amd.com/en-us/download
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#27 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADvIyHmYoW6kltkS8cmBHvRM9g9lHJrRks5t1b20gaJpZM4RPbFB>
.
|
I update all the drivers and sometimes the bugs appear. But although much less than before. |
likewise, usually restarting the game helps, but every now and then it reappears just to rub it in your face that "hey, you still can't quite play this game fully" |
Same here, got maybe 15 minutes of time in before the glitch fired back up. My dream is that I'll actually be able to play this game by the end of 2018. |
I'd strongly suggest leaving a response on this page: http://amd.com/report Don't expect a response, but describe your issue, your GPU, and point back to this comment page (paste the URL). Bugging AMD to fix their drivers is probably the best way to get this fixed. |
Give 18.5.2 a try and see if it still an issue. Was released on the 30th. |
Just did a small test with the latest drivers and I can say it does look like everything is fixed but I cannot say if it is the result of the latest drivers since i know vrc updated a few days ago. |
I just did a test myself today and everything was fixed with 18.5.2! I was able to swap to different avatars just fine, worlds loaded up perfectly. |
If it is true that it is completely fixed (I only have vega so im not sure about rx4xx and rx5xx), then it mustve been related too "Shader Cache may sometimes fail to enable or may not correctly cache shaders for games." |
honestly it seems for most people you just keep restarting till it works
and doing it more often or not till eventually and some random update it
works for them no problem lol. no longer running 580 though it randomly
quite breaking a while back for me on it then I switched to vega.
…On Mon, Jun 4, 2018 at 10:27 PM, Darius Clark ***@***.***> wrote:
If it is true that it is completely fixed (I only have vega so im not sure
about rx4xx and rx5xx), then it mustve been related too "Shader Cache may
sometimes fail to enable or may not correctly cache shaders for games."
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#27 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHZVkNk6cUt1Oy5jQSe5jhQ_3mu4zRLyks5t5fqOgaJpZM4RPbFB>
.
|
18.5.2 seems to be a fix. I just wanted to thank everyone for the constant effort I have been keeping track since I commented on this thread Jan 7th. |
Played for nearly two hours today without the glitch activating at all. I think it may actually be fixed! Been waiting and hoping since last December, so I am quite excited right now. |
Internal VRChat team has confirmed on AMD hardware that this issue is fixed with the latest drivers. |
Theres currently a bug with RX 400 and RX 500 gpus where models with "Flat lit toon shader" will turn up invisible. Here's a few bug reports on VRChat about it.
https://vrchat.canny.io/bug-reports/p/avatars-mine-as-well-disappearing-bug-w-flat-lit-shader-or-amd https://docs.vrchat.com/v1.0/discuss/5a40b0ff3cdca90012583e89 https://docs.vrchat.com/v1.0/discuss/5a45880af1af410030ded733 https://docs.vrchat.com/v1.0/discuss/5a28f9eb85546e001c0f4754
The text was updated successfully, but these errors were encountered: