Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(doc): Update the Governance Document #3382

Merged

Conversation

leonrayang
Copy link
Member

Motivation

The description of "project lead" implies a somewhat authoritarian role, but with the establishment of a steering committee, the steering committee should be considered the highest decision-making body.

Modifications

Canceling the position of "project lead," the steering committee has the authority to decide on the majority of matters. By voting through the steering committee, disputes can be resolved completely, eliminating the need for a project lead.

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Bugfix (non-breaking change which fixes an issue)
  • Documentation Update (if none of the other choices apply)
  • So on...

Verifying this change

  • Make sure that the change passes the testing checks.

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • This can be verified in development debugging
  • This can be realized in a mocked environment, like a test cluster consisting in docker

(or)

This change MUST reappear in online clusters, or occur in that specific scenarios.

Does this pull request potentially affect one of the following parts:

  • Master
  • MetaNode
  • DataNode
  • ObjectNode
  • AuthNode
  • LcNode
  • Blobstore
  • Client
  • Cli
  • SDK
  • Other Tools
  • Common Packages
  • Dependencies
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Review Expection

  • in-two-days
  • weekly
  • free-time
  • whenever

Matching PR in forked repository

PR in forked repository:

Copy link

netlify bot commented May 20, 2024

Deploy Preview for cubefs-check ready!

Name Link
🔨 Latest commit 77c308c
🔍 Latest deploy log https://app.netlify.com/sites/cubefs-check/deploys/66543b34b4012d0008ebe76f
😎 Deploy Preview https://deploy-preview-3382--cubefs-check.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@Victor1319 Victor1319 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cessory
Copy link
Collaborator

cessory commented May 20, 2024

+1

3 similar comments
@Victor1319
Copy link
Member

+1

@Cloudstriff
Copy link
Member

+1

@leonrayang
Copy link
Member Author

+1

@xiaochunhe xiaochunhe removed their request for review May 20, 2024 03:15
@sejust
Copy link
Collaborator

sejust commented May 20, 2024

+1

@xiaochunhe xiaochunhe self-requested a review May 20, 2024 03:18
Copy link
Contributor

@xiaochunhe xiaochunhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Member

@mervinkid mervinkid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve +1

@bladehliu
Copy link
Member

+1

Signed-off-by: leonrayang <chl696@sina.com>
@leonrayang leonrayang force-pushed the leonchang/github-master-governance branch from e65eed5 to 77c308c Compare May 27, 2024 07:50
@leonrayang leonrayang merged commit f094702 into cubefs:master May 27, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants