Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated server settings tab #101

Merged
merged 4 commits into from
Dec 1, 2014
Merged

Updated server settings tab #101

merged 4 commits into from
Dec 1, 2014

Conversation

Howaner
Copy link
Contributor

@Howaner Howaner commented Nov 29, 2014

No description provided.

@Howaner
Copy link
Contributor Author

Howaner commented Nov 30, 2014

Any objections?

@NiLSPACE
Copy link
Member

I can take your word for it that it works? :)

@Howaner
Copy link
Contributor Author

Howaner commented Nov 30, 2014

@STRWarrior yes :)

local function HTML_Option( value, text, selected )
if( selected == true ) then
local function HTML_Option(value, text, selected)
if (selected == true) then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can Lua do simply if (selected) then?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it can

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And it's even preferable to comparing to bool values.

@Howaner
Copy link
Contributor Author

Howaner commented Dec 1, 2014

done.

madmaxoft added a commit that referenced this pull request Dec 1, 2014
Updated server settings tab
@madmaxoft madmaxoft merged commit 4183d6c into master Dec 1, 2014
@NiLSPACE NiLSPACE deleted the WebAdmin branch May 21, 2015 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants