Added gamerule command #194

williamhatcher · 2017-08-10T00:01:50Z

/gamerule will list all game rules, show the value of a game rule, or set a game rule.

This does not implement the actual game rules!

Also, there are a few differences between this and the vanilla command.

Trying to set spawnRadius to hello or anything other than a number will fail (try it out in vanilla!)
Tab-completion does not work. I would have to specify the default game rules as subcommands in the Info.lua file, and that would prevent the inclusion of custom game rules.
There are a few other minor differences, but I've done my best to make it compatible with the vanilla command.

There's a bug that I've found, can reproduce, but can't find a pattern to.
When you try to retrieve a previously set game rule, the plugin cannot recall it in the GameRules table, but the rule is visible when you list the game rules. (also, the value is stored)

williamhatcher · 2017-08-15T17:24:48Z

Can I get some feedback on this?

mathiascode · 2017-08-15T18:09:40Z

Gamerules are per world, so I think it would make more sense to store them in the world.ini file. The best would be to store them in level.dat, since vanilla does that, but that would probably require some changes in Cuberite itself.

williamhatcher · 2017-08-15T20:22:31Z

I noticed that the default gamerules.ini file wasn't pushed, and fixed it.

I can move the game rules to the world.ini file. This will add a small amount of overhead, but I think it will be worth it.

madmaxoft · 2017-08-17T13:08:52Z

One thing I'm definitely against is having a hardcoded path for the INI file (like you did in commit 2f14d0d). The original version was better; storing them per-world would be the best, of course. Somehow CircleCI won't let me see the error I assume you were fixing with the hardcoded path, it's most likely a bug in the plugin checker.

madmaxoft

Could we simplify by pretending all gamerules are string values and only their interpreter (once implemented) will convert such a value to whatever type it needs? It would simplify a lot of stuff.

Alternatively, use the string handling for all unknown gamerules, and for the known ones, we'll have a table of them and their handlers somewhere, so that table could also specify the type of the parameter.

madmaxoft · 2017-08-17T13:10:32Z

Info.lua

+				},
+				{
+					Params = "rule value",
+					Help = "Sets a game rule value",


Probably should get a "WorldName" param, too.

When I move the rules to the world ini, I'll change this

The params should be correct from the start, even if not used. Makes migration easier.

I've fixed this

madmaxoft · 2017-08-17T13:11:10Z

Info.lua

+			Description = "Allows players to set and query game rule values",
+			RecommendedGroups = "admins",
+		},
+


Would it make sense to have a separate permission for querying, and a separate one for setting?

Yes. I'll add them to the permissions table.

@madmaxoft Should I have core.gamerule allow setting and querying,
core.gamerule.query for querying and listing only, and
core.gamerule.set for setting only or setting and querying?

Nevermind, I just made the description vague

madmaxoft · 2017-08-17T13:13:51Z

gamerule.lua

+local grDB
+local ini = cIniFile()
+local boolean = "boolean"
+local number = "number"


These two lines are rather weird, can you change the name of the variables to something more descriptive of what they're used for?

They won't be needed when I remove the game rule types

Done, removed.

madmaxoft · 2017-08-17T13:16:25Z

gamerules.ini

@@ -0,0 +1,75 @@
+;Game Rules
+;This file contains all the set game rules
+;All values here can be configured using the webadmin interface, if enabled


I don't see any webadmin handlers to support this claim.

I haven't added this yet, but rest assured that it will be added.

madmaxoft · 2017-08-17T13:23:49Z

It'd be great to have at least one gamerule actually implemented, so that we can see how it integrates with this groundwork.

williamhatcher · 2017-08-23T20:31:09Z

Could we simplify by pretending all gamerules are string values and only their interpreter (once implemented) will convert such a value to whatever type it needs? It would simplify a lot of stuff.

The problem with this is that there's no validation when setting game rules, also, some of the interpreters will be called lots of times, mobGriefing for example, and It would be very slow if they had to convert the value each time they were called. Maybe interpreters could register a function for validation?
Maybe like: AddValidation(a_Rule, a_Callback) where a_Rule is a string, and a_Callback is a function?

If cPluginManager:RemoveHook existed, then the plugin could add and remove hook callbacks as needed, but right now, all possible hook callbacks have to be registered, and ran each time a hook emits. This forces the interpreter to check if it should even do anything each time it is ran.

williamhatcher · 2017-08-24T04:28:00Z

Wow!

I changed a bunch of stuff. Here's a summary:

Added a new validation system like WE's hook system.
Switched to world based game rules
Added world parameters (but they aren't implemented)
Tried to clean up the code
Separated the large file into two smaller files
I'm really really sorry for the super large commit.

To allow setting of world context in the console

williamhatcher · 2017-08-25T02:06:47Z

@madmaxoft, What do you think of the changes so far?

Removed duplicate code and made setting values more flexable.

williamhatcher · 2017-08-25T02:44:32Z

Now the console and in game commands work the same way.
You are now able to set values with spaces in them!

williamhatcher · 2017-08-25T15:25:26Z

Note to self: have SaveValue store the value in GameRules table

williamhatcher · 2017-08-27T20:31:20Z

@madmaxoft do you mind looking at my new commits?

mathiascode · 2019-12-05T14:15:30Z

This should probably be implemented as a proper API in the server core.

williamhatcher added 10 commits August 8, 2017 10:42

Added gamerule cmd to Info.lua

fa1a10b

Added console cmd & perms

15aaf7d

Updated README.md

6934676

Added gamerule.lua

22be076

Ignores EnableMobDebug.lua

d5235bc

Added ini file loading

076383c

You can now get/set game rules

fabf613

Removed debugging code

feb4f4b

Fixed saving booleans, In-game cmd works now

5da449a

Moved to hard path

2f14d0d

Added default gamerules.ini

10b1241

madmaxoft requested changes Aug 17, 2017

View reviewed changes

This was referenced Aug 21, 2017

Fix plugin path bug cuberite/CuberitePluginChecker#36

Closed

Add flags to Protection Areas cuberite/ProtectionAreas#17

Closed

Implement /gamerule command cuberite/cuberite#1693

Open

Added world params

31f997d

Added a bunch of stuff

6b7dbbf

williamhatcher added 4 commits August 23, 2017 21:34

Added separate perms

2542ac9

Merge branch 'master' into gamerule-push

e6205ef

Added newline to .gitignore

767723a

Added gamerule-world console command

4b5bdbe

To allow setting of world context in the console

Updated commands

add11aa

Removed duplicate code and made setting values more flexable.

mathiascode closed this Dec 5, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added gamerule command #194

Added gamerule command #194

williamhatcher commented Aug 10, 2017

williamhatcher commented Aug 15, 2017

mathiascode commented Aug 15, 2017

williamhatcher commented Aug 15, 2017

madmaxoft commented Aug 17, 2017

madmaxoft left a comment

madmaxoft Aug 17, 2017

williamhatcher Aug 21, 2017

madmaxoft Aug 22, 2017

williamhatcher Aug 23, 2017 •

edited

madmaxoft Aug 17, 2017

williamhatcher Aug 21, 2017

williamhatcher Aug 24, 2017

williamhatcher Aug 24, 2017

madmaxoft Aug 17, 2017

williamhatcher Aug 21, 2017

williamhatcher Aug 24, 2017

madmaxoft Aug 17, 2017

williamhatcher Aug 21, 2017

madmaxoft commented Aug 17, 2017

williamhatcher commented Aug 23, 2017 •

edited

williamhatcher commented Aug 24, 2017 •

edited

williamhatcher commented Aug 25, 2017

williamhatcher commented Aug 25, 2017

williamhatcher commented Aug 25, 2017

williamhatcher commented Aug 27, 2017

mathiascode commented Dec 5, 2019

Added gamerule command #194

Added gamerule command #194

Conversation

williamhatcher commented Aug 10, 2017

williamhatcher commented Aug 15, 2017

mathiascode commented Aug 15, 2017

williamhatcher commented Aug 15, 2017

madmaxoft commented Aug 17, 2017

madmaxoft left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

williamhatcher Aug 23, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

madmaxoft commented Aug 17, 2017

williamhatcher commented Aug 23, 2017 • edited

williamhatcher commented Aug 24, 2017 • edited

Wow!

williamhatcher commented Aug 25, 2017

williamhatcher commented Aug 25, 2017

williamhatcher commented Aug 25, 2017

williamhatcher commented Aug 27, 2017

mathiascode commented Dec 5, 2019

williamhatcher Aug 23, 2017 •

edited

williamhatcher commented Aug 23, 2017 •

edited

williamhatcher commented Aug 24, 2017 •

edited