Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Writing cBlockArea doesn't update BlockEntities #465

Closed
madmaxoft opened this issue Dec 23, 2013 · 2 comments
Closed

Writing cBlockArea doesn't update BlockEntities #465

madmaxoft opened this issue Dec 23, 2013 · 2 comments

Comments

@madmaxoft
Copy link
Member

Writing a cBlockArea into the world needs to check block entities - existing ones may have been overwritten and new ones may need creating.

An easy way to verify this: combine the Debuggers plugin with Gallery plugin. Debuggers place a sign at each chunk's corner, then Gallery, when claiming an area, overwrites everything with the predefined area schematic; the sign is lost, yet the block entity stays even after server restart and is sent to the client; the client then complains "sign at X, Y, Z not found"

@pwnorbitals
Copy link
Contributor

Is this still an existing bug ? @madmaxoft, can you still reproduce ?

@NiLSPACE
Copy link
Member

The code to delete them is there, so this is fixed: https://github.com/cuberite/cuberite/blob/master/src/Chunk.cpp#L423-L434

It was added in #3795

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants