Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New parameter to enable base64 password #87

Closed
vviau opened this issue Jan 25, 2019 · 1 comment
Closed

New parameter to enable base64 password #87

vviau opened this issue Jan 25, 2019 · 1 comment
Assignees
Milestone

Comments

@vviau
Copy link
Member

vviau commented Jan 25, 2019

Currently, TM1py checks first if the "password" is encoded, then if it fails to login with the password decoded, it tries with the password as it is. It means that if you have a wrong password, TM1py is going to use 2 failed attempts instead of just 1. This can lead to reaching the maximum of attempts very quickly and locked our Admin user.

To avoid this we could add a new parameter in the config.ini, called "password64" or if we want to make it less obvious it could be "pwd", the new parameter will be used to put the encoded password. TM1py could check first if there is a value for this new parameter then it tries to connect, if there is no value, TM1py will get the password from the parameter "password".

For example, "password" will always be plain password and "password64", the encoded password.

Cheers,

Vincent

@vviau
Copy link
Member Author

vviau commented Jan 25, 2019

Or the other option would be to use a new parameter called "decode64" = true or false. This solution might be better for backward compatibility

@MariusWirtz MariusWirtz self-assigned this Jan 28, 2019
MariusWirtz added a commit to MariusWirtz/TM1py that referenced this issue Feb 2, 2019
MariusWirtz added a commit to MariusWirtz/TM1py that referenced this issue Feb 2, 2019
- Fixes cubewise-code#87
- Refactoring Element class
MariusWirtz added a commit to MariusWirtz/TM1py that referenced this issue Feb 2, 2019
- Fixes cubewise-code#87
- Refactoring Element class
MariusWirtz added a commit to MariusWirtz/TM1py that referenced this issue Feb 2, 2019
- Fixes cubewise-code#87
- Refactoring Element class
@MariusWirtz MariusWirtz added this to the 1.3.0 milestone Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants