Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subset update function relies on ti and requires refactoring #93

Closed
MariusWirtz opened this issue Feb 4, 2019 · 0 comments
Closed

Subset update function relies on ti and requires refactoring #93

MariusWirtz opened this issue Feb 4, 2019 · 0 comments
Assignees
@MariusWirtz
Milestone
1.3.0

Comments

@MariusWirtz
Copy link
Collaborator

Currently the update method in the SubsetServices uses the SubsetDeleteAllElements TI function, behind the scenes, when updating static public subsets.

This is a relic from TM1 version 10.2.2 FP 6, when there was no official way to clear all elements from a static subset through the REST API. TM1 11 provides this functionality through standard API calls.
The update method needs to be refactored, in order to make us of the standard functionality instead of TI.
@MariusWirtz MariusWirtz added this to the 1.3.0 milestone Feb 4, 2019
@MariusWirtz MariusWirtz self-assigned this Feb 4, 2019
MariusWirtz added a commit to MariusWirtz/TM1py that referenced this issue Feb 4, 2019
@MariusWirtz
Refactoring of update method in SubsetService. Fixes cubewise-code#93
a43b314 
- make use of api to remove all elements from a static subset
- refactoring of test cases for subset operations
- introduces new is_dynamic, is_static methods on Subset class
MariusWirtz added a commit to MariusWirtz/TM1py that referenced this issue Feb 4, 2019
@MariusWirtz
Refactoring of update method in SubsetService. Fixes cubewise-code#93
7dfc4b1 
- make use of api to remove all elements from a static subset
- refactoring of test cases for subset operations
- introduces new is_dynamic, is_static methods on Subset class
@MariusWirtz MariusWirtz mentioned this issue Feb 4, 2019
Merged
MariusWirtz added a commit to MariusWirtz/TM1py that referenced this issue Feb 4, 2019
@MariusWirtz
Refactoring of update method in SubsetService. Fixes cubewise-code#93
4944b62 
- make use of api to remove all elements from a static subset
- refactoring of test cases for subset operations
- introduces new is_dynamic, is_static methods on Subset class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MariusWirtz MariusWirtz

Labels
None yet
Projects
None yet
Milestone
1.3.0
Development

No branches or pull requests
1 participant
@MariusWirtz