Support for LibreSSL #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only libressl does not match option name and software name.
catatsuy
commented
May 27, 2017
|
|
||
| // only libressl does not match option name | ||
| if name == "libressl" { | ||
| name = "openssl" |
There was a problem hiding this comment.
Only libressl does not match option name and software name. So I rewritten the option name here.
| @@ -23,7 +23,7 @@ func Generate(configure string, modules3rd []module3rd.Module3rd, dependencies [ | |||
|
|
|||
| for _, d := range dependencies { | |||
| configure += fmt.Sprintf("%s=../%s-%s \\\n", d.Option, d.Name, d.Version) | |||
| if d.Name == "openssl" { | |||
| if d.Name == "openssl" || d.Name == "libressl" { | |||
There was a problem hiding this comment.
The options required by OpenSSL are also required for LibreSSL.
| @@ -188,6 +190,9 @@ func main() { | |||
| if *openResty && *tengine { | |||
| log.Fatal("select one between '-openresty' and '-tengine'.") | |||
| } | |||
| if *openSSLStatic && *libreSSLStatic { | |||
There was a problem hiding this comment.
Both -openssl and -libressl cannot be enabled at the same time.
|
LGTM. Could you add documents to README.md? |
|
@cubicdaiya Thank you. I add documents for |
|
Merged. Thanks. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only libressl does not match option name and software name.