refactoring

cubiche · May 1, 2016 · b727958 · b727958
1 parent c5a810f
commit b727958
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/Promise/FulfilledPromise.php b/Promise/FulfilledPromise.php
@@ -28,6 +28,9 @@ class FulfilledPromise extends AbstractPromise
      */
     public function __construct($value = null)
     {
+        if ($value instanceof PromiseInterface) {
+            throw new \InvalidArgumentException(\sprintf('You cannot create %s with a promise.', self::class));
+        }
         $this->value = $value;
     }
 

diff --git a/Tests/Units/Promise/FulfilledPromiseTests.php b/Tests/Units/Promise/FulfilledPromiseTests.php
@@ -8,7 +8,6 @@
  * For the full copyright and license information, please view the LICENSE
  * file that was distributed with this source code.
  */
-
 namespace Cubiche\Core\Async\Tests\Units\Promise;
 
 /**
@@ -35,4 +34,17 @@ protected function promiseDataProvider()
             array($this->newDefaultTestedInstance()),
         );
     }
+
+    /**
+     * Test __construct.
+     */
+    public function testConstruct()
+    {
+        $this
+            ->exception(function () {
+                $this->newTestedInstance($this->newDefaultTestedInstance());
+            })
+            ->isInstanceOf(\InvalidArgumentException::class)
+        ;
+    }
 }