Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit Testing (+UI Testing) #89

Open
michalbe opened this issue Mar 6, 2014 · 6 comments
Open

Unit Testing (+UI Testing) #89

michalbe opened this issue Mar 6, 2014 · 6 comments

Comments

@michalbe
Copy link
Contributor

michalbe commented Mar 6, 2014

While project is getting bigger & bigger, it would be nice to have some tests - it will be easier to prevent regressions.

@lgarron
Copy link
Member

lgarron commented Mar 6, 2014

Totally.
twisty.js will need some by the time cubing/twisty.js#42 happens. alg.cubing.net can probably run fine on phantom, as long as we don't test WebGL.

@lgarron
Copy link
Member

lgarron commented Mar 6, 2014

Have you noticed any regressions in particular?

I haven't really had an issue with them yet, but that's probably because I know the whole project.
(index.html in twisty.js has not had as good a fate, but I'm not worrying about it right now.)

@michalbe
Copy link
Contributor Author

michalbe commented Mar 6, 2014

Not so far, but forewarned is forearmed. I don't think we want to test WebGL, Three has it's own tests for this and I'm quite sure we can trust them.

@lgarron lgarron changed the title unit / ui tests Unit Testing (+UI Testing) Jul 5, 2014
@lgarron lgarron mentioned this issue Jul 5, 2014
@lgarron
Copy link
Member

lgarron commented Jul 5, 2014

  • Encoding
    • + should be encoded as %2B so that + in the URL can be interpreted as a space.

@StachuDotNet StachuDotNet self-assigned this Aug 29, 2014
@StachuDotNet
Copy link

Does anyone have a problem with jasmine + karma? Doing a big refactor now.
Have some minor tests in place, and don't want to get too deep before someone has problems.

@lgarron
Copy link
Member

lgarron commented Aug 30, 2014

Sounds fine. In any case, no one except me and you is actually active on this project right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants