Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cubing.js issue] Incomplete turns in <twisty-alg-viewer> #315

Closed
bohdancho opened this issue Jan 21, 2024 · 2 comments
Closed

[cubing.js issue] Incomplete turns in <twisty-alg-viewer> #315

bohdancho opened this issue Jan 21, 2024 · 2 comments
Labels
🐞 bug Something isn't working

Comments

@bohdancho
Copy link

bohdancho commented Jan 21, 2024

Steps to reproduce the issue

  1. Go to https://experiments.cubing.net/cubing.js/twisty/twisty-alg-viewer.html
  2. Click on any move in <twisty-alg-viewer>

Observed behaviour

The cube jumps to the selected move, but the turn is not visually finished (as in the cube is slightly out of cubic shape). A click on "step forward" plays the remaining bit of the selected move and fixes the shape instead of playing a new move.

🖼 Screenshots

image

Expected behaviour

I would expect turns to always look complete after jumping to a move. Which would look the same is if I would manually navigate to the same move with step forward/backward buttons.

Environment

Google Chrome Version 120.0.6099.225 (Official Build) (64-bit)

Additional info

I'm going to use <twisty-alg-editor> with readonly as a workaround for now, I'm also thinking about forcing selections to always end at the end of an alg leaf, never in the middle or in the beginning.

I would have to fork cubing.js and tweak the source code for this.

Is there a better alternative?

@bohdancho bohdancho added the 🐞 bug Something isn't working label Jan 21, 2024
@lgarron
Copy link
Member

lgarron commented Jan 22, 2024

This is by design, to indicate what move is being performed at the given index. This is similar to how alg.cubing.net and Twizzle show what move you're on. In the long term I'd like to find something better (perhaps animating the given move).

Could you share more about why you need different functionality?

@bohdancho
Copy link
Author

Now that you put it this way, it makes sense to me so I don't need different functionality. Thanks for the clarification!

@bohdancho bohdancho reopened this Jan 23, 2024
@bohdancho bohdancho closed this as not planned Won't fix, can't repro, duplicate, stale Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants