Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3D visualization background is always checkered #7

Closed
big213 opened this issue Jul 11, 2020 · 2 comments
Closed

3D visualization background is always checkered #7

big213 opened this issue Jul 11, 2020 · 2 comments

Comments

@big213
Copy link
Member

big213 commented Jul 11, 2020

Seems to have started happening between 0.1.1 and 0.2.1

<scramble-display scramble="F' D F2 L2 U' R2 U' F2 D2 R2 F2 U2 F R' B F D' B2 U B'" visualisation="3D"></scramble-display>
@lgarron
Copy link
Member

lgarron commented Jul 13, 2020

Indeed, this is from 1a1f6fd. I need to push the checkered CSS configuration into cubing.js itself.

lgarron added a commit that referenced this issue Jul 13, 2020
@lgarron
Overhaul the checkered implementation. Fixes #7.
aad1aef 
The SVG views don't yet use `TwistyPlayer`, so we need to use a separate implementation for each viewer type. As a further complication, we can't reach into the shadow dom of the 3D implementations to override their CSS.

It would be simple to handle the checkering ourselves (i.e. set the 3D `TwistyPlayer`s to uncheckered), but I eventually want to move as much of this library as possible into `cubing.js` itself.
@lgarron
Copy link
Member

lgarron commented Jul 13, 2020 •
edited
Loading

This should be fixed in v0.2.3! Thanks for reporting, it was valuable to know that this was happening!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lgarron @big213