destroy() does not cancel resizeTimeout #924

unilynx · 2015-06-08T08:53:48Z

I'm seeing javascript errors if I destroy an iscroll in my window onResize handler:

Uncaught TypeError: Cannot read property 'length' of undefined_indicatorsMap
@ iscroll.js?c=DToLACPt4QE:975(anonymous function)
@ iscroll.js?c=DToLACPt4QE:1008IScroll._execEvent
@ iscroll.js?c=DToLACPt4QE:739IScroll.refresh
@ iscroll.js?c=DToLACPt4QE:698(anonymous function)
@ iscroll.js?c=DToLACPt4QE:624

From what I can tell, one of the destroy handlers should have cleared resizeTimeout.

sculove · 2015-08-05T10:03:23Z

I agree!
I fix it

Look at this PR
#950

ref #924, #950

ref cubiq#924, cubiq#950

sculove mentioned this issue Aug 5, 2015

destroy() does not cancel timeouts #950

Closed

unilynx closed this as completed Sep 14, 2015

sculove added a commit that referenced this issue Mar 28, 2016

clean up timer on destroy

a375851

ref #924, #950

aisouard pushed a commit to Mappy/iscroll that referenced this issue Feb 22, 2017

clean up timer on destroy

521ef67

ref cubiq#924, cubiq#950

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

destroy() does not cancel resizeTimeout #924

destroy() does not cancel resizeTimeout #924

unilynx commented Jun 8, 2015

sculove commented Aug 5, 2015

destroy() does not cancel resizeTimeout #924

destroy() does not cancel resizeTimeout #924

Comments

unilynx commented Jun 8, 2015

sculove commented Aug 5, 2015