-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calyx Backend uses static groups instead of attribute #400
Conversation
} | ||
group let1<"static"=1> { | ||
static group <1> let1 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused, I thought the latency attribute comes after the name? Also, can we get rid of the space between the name and the latency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah yeah my bad. I'll change it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One clarification question but LGTM otherwise!
Wahoo; nice work on this! |
@calebmkim just checking what's the status of this PR? |
Ah, we can merge it. I was just thinking, though: without the |
Hm, that's a fair point! Should we wait till control promotion stuff is done and then merge it as a part of our efforts to close out the static groups milestone? |
Not going to merge this. We have decided to just emit |
Simple change to use
static group <lateny>
instead of<"static"=latency>
for the Calyx backend.