Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parsing issue of hex numbers in cast expr #412

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Fix parsing issue of hex numbers in cast expr #412

merged 1 commit into from
Jan 30, 2024

Conversation

Mark1626
Copy link
Collaborator

Summary

  1. Make the parser use the same logic as Octal literals
  2. Add tests for this scenario

Closes #411

@rachitnigam
Copy link
Member

LGTM!

@rachitnigam rachitnigam merged commit 84f5449 into cucapra:master Jan 30, 2024
@Mark1626 Mark1626 deleted the hex-parse-issue branch January 30, 2024 09:57
rachitnigam pushed a commit that referenced this pull request Feb 16, 2024
@Mark1626 @rachitnigam
Fix parsing issue of hex numbers in cast expr (#412)
2116ed3
rachitnigam added a commit that referenced this pull request Mar 8, 2024
@calebmkim @Mark1626 @rachitnigam
Fix Seq Mem Ports (#401)
9ec9a58 
* fix seq mem ports

* Handle TRecType in areEqual (#404)

* Update documentation types and views (#406)

* BigInt in EInt to allow large literals in let (#409)

* Fix parsing issue of hex numbers in cast expr (#412)

* Fix issue in C++ backend when passing let variable to functions (#414)

* @static -> @Promotable

* fix test

* update scala and sbt versions

* Use new location for Calyx primitives

* explicit type

* update tests

* period to docs

* i hate vscode

* dont generate write_en assignment for reads

---------

Co-authored-by: Nimalan <nimalan.m@protonmail.com>
Co-authored-by: Rachit Nigam <rachit.nigam12@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parse issue for hexadecimal literals in cast expressions
2 participants
@Mark1626 @rachitnigam