Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support unrolling functions with scalar arguments inside unrolled loops #419

Merged
merged 3 commits into from
Mar 3, 2024

Conversation

Mark1626
Copy link
Collaborator

@Mark1626 Mark1626 commented Mar 3, 2024

Closes #418

Summary:

  1. Implement the trait Tracker in WFEnv, to track function definitions
    • I've kept the key as Id -> FuncDef. This could have been Id -> Boolean, but it seemed too specific to this scenario for the WFEnv
  2. Add a canHaveFunctionInUnroll function which will check from the env if the function can be present inside a unrolled loop
  3. Update existing test case (which had scalar arguments) and add a new test case (with an array in the argument)

@rachitnigam
Copy link
Member

Awesome, LGTM! Thanks @Mark1626

@rachitnigam
Copy link
Member

@Mark1626 BTW, it seems that the CI still doesn't run because of borked permissions. I am going give you write access to the repo so you can directly open branches within the repo and have the CI actually run.

@rachitnigam rachitnigam merged commit d0480c9 into cucapra:master Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question about using functions in unrolled loop
2 participants