Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Scala 3.3.1 LTS #421

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Migrate to Scala 3.3.1 LTS #421

merged 1 commit into from
Mar 5, 2024

Conversation

Mark1626
Copy link
Collaborator

@Mark1626 Mark1626 commented Mar 4, 2024

Summary

  1. Bumped up version of scalatest, fastparse, sbtassembly, scalafmt
  2. Used the compiler opt -new-syntax along with -rewrite to format the code after a successful compile
  3. Changes made in source getClass.getResourceAsStream("/version.properties") -> scala.io.Source.fromResource("version.properties")
  4. The compiler noted that in certain cases where for an Option[T] type only Some[T] was consumed and None was ignored. This has been temporarily marked with @unchecked
  5. Fatjar construction had a considerable change as sbtassembly went up from 0.14.9 to 2.1.5 in build.sbt
  6. The Dotty Compiler cleared minor issues in pattern matching that were marked eg)Parser.scala L418, calyx/Backend.scala
  7. Main function still follows Scala 2 pattern rather than a Scala 3 @main approach
  8. Tested with the existing unit tests and functional tests
  9. The documentation is out of date, should I do this in this PR itself.

Note: Most of this was just a straightforward version update except for point 4 and 5


Let me know your feedback, I'll work on them.

@rachitnigam
Copy link
Member

Freaking awesome!! LGTM! Merge it!

@Mark1626
Copy link
Collaborator Author

Mark1626 commented Mar 5, 2024

Any comments on point 4

@rachitnigam
Copy link
Member

How about (once this is merged), opening a new PR immediately where the @unchecked is remove so we can stare at the error message and see which places are obviously incorrect and which places can be handled directly

@Mark1626
Copy link
Collaborator Author

Mark1626 commented Mar 5, 2024

Sounds good. Do you want me to merge it to master?

@rachitnigam
Copy link
Member

Yup! You should have access to hit the green button now!

@rachitnigam
Copy link
Member

I generally prefer squash commits BTW

@Mark1626 Mark1626 merged commit 410d42b into master Mar 5, 2024
1 check passed
@Mark1626 Mark1626 deleted the scala3-migration branch March 5, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants