Scala rewrite #46
Scala rewrite #46
Conversation
Don't require `-f` to pass the file to parse; it's now a positional argument.
There was a problem hiding this comment.
This is looking good! I'm happy with how things are going in the Scala incantation. (The only drawback is indeed startup time—sbt really is the opposite of ocamlc in that sense!)
Aside from the notes I've left inline during a review, here are a few quick notes:
- A bit more commenting could really help with medium-term maintainability.
- I like the new small language-feature test suite!!
- It looks like the old collection of larger examples (in
examples) needs updating to sync with the new implementation.
src/main/scala/TypeCheck.scala
Outdated
| if (t2 :< t1) (t1, t2, lhs) match { | ||
| // Reassignment of static ints upcasts to bit<32> | ||
| case (TStaticInt(_), TStaticInt(_), EVar(id)) => | ||
| e2.updateBind(id -> Info(id, TSizedInt(32))) |
There was a problem hiding this comment.
It would be nice to make sure that the number fits into a 32-bit size. And even if not, it could be sensible to put the default integer type into a constant somewhere.
I realize this seems like a low-level detail, but this could actually be a deeper question: we might want to let people specify the default numeric type within a scope. Because numeric widths are so important for accelerator efficiency, people often want to decide the numeric type for an entire design or module at once. That should probably affect (most?) literals as well as the buffers they eventually flow into. Seems sort of tricky.
There was a problem hiding this comment.
Explicitly typed let allows you to specific the exact type of constants. Is that what you’re talking about?
|
Re: Examples. They have been moved to src/test/resources and are run with the test suite. The examples directory is used by Sachille for something, but he can starting migrating things to the same place. |
Fixes #44 #41 #37 #30. Subsumes #40 #43.
TODO
views