Skip to content
This repository has been archived by the owner on Apr 26, 2021. It is now read-only.

Search improvements #2390

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Search improvements #2390

wants to merge 2 commits into from

Conversation

raveneous
Copy link

What I have added/changed is:
  • postpone search
  • correct fulltext search
  • size of search query from default value to 1000
The goal of my change is:

-postpone search in order to not blown up elasticsearch with unfinished queries

  • correct fulltext search, so you can search as expected
  • size of search query from default value to 1000 to get all results
What I have tested about my change is:

All

As noted in commit message, maybe take into consideration ability to select search size from web interface.

Before pull request, wildcard was not correctly used, so search did not work as expected. Also default size of 10 is not enough. Maybe allow to select search size from web interface ?
Query elasticsearch after 1 second of no typing instead of querying it after every character typed.
@codecov-io
Copy link

codecov-io commented Jul 23, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@df55177). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #2390   +/-   ##
========================================
  Coverage          ?     62%           
========================================
  Files             ?     152           
  Lines             ?   15177           
  Branches          ?       0           
========================================
  Hits              ?    9410           
  Misses            ?    5767           
  Partials          ?       0
Impacted Files Coverage Δ
cuckoo/web/analysis/views.py 24.89% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df55177...e6cd1a3. Read the comment docs.

@coveralls
Copy link

coveralls commented Jul 23, 2018

Coverage Status

Coverage remained the same at 61.949% when pulling e6cd1a3 on raveneous:master into c41c7c5 on cuckoosandbox:master.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants